[GitHub] [incubator-openwhisk] sven-lange-last commented on a change in pull request #4430: Update docker client version to 18.06.3

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #4430: Update docker client version to 18.06.3
URL: https://github.com/apache/incubator-openwhisk/pull/4430#discussion_r281639679
 
 

 ##########
 File path: tests/src/test/scala/ha/ShootComponentsTests.scala
 ##########
 @@ -305,9 +305,8 @@ trait ShootComponentUtils {
     def file(path: String) = Try(new File(path)).filter(_.exists).map(_.getAbsolutePath).toOption
 
     val docker = (file("/usr/bin/docker") orElse file("/usr/local/bin/docker")).getOrElse("docker")
-    val dockerPort = WhiskProperties.getProperty(WhiskConfig.dockerPort)
 
-    Seq(docker, "--host", host + ":" + dockerPort, cmd, component)
+    Seq(docker, cmd, component)
 
 Review comment:
   How is the test supposed to work if there is more than one controller running and the controllers run on different systems?
   
   The original test code determines which host is running the first controller and would ask the remote host's Docker daemon to start, stop and restart the controller container. With the change, the test permanently fails in our test environment that uses multiple systems in parallel.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services