Re: [PR] chore(deps): Update sqlparser to `0.54.0` [datafusion]

["goldmedal (via GitHub)" <gi...@apache.org>]

goldmedal commented on code in PR #14255:
URL: https://github.com/apache/datafusion/pull/14255#discussion_r1942699530


##########
datafusion/sql/src/planner.rs:
##########
@@ -566,7 +569,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
             | SQLDataType::MediumText
             | SQLDataType::LongText
             | SQLDataType::Bit(_)
-            |SQLDataType::BitVarying(_)
+            | SQLDataType::BitVarying(_)
+            // BIG Query UDFs

Review Comment:
   ```suggestion
               // BigQuery UDFs
   ```



##########
datafusion/sqllogictest/test_files/joins.slt:
##########
@@ -2623,6 +2623,10 @@ SELECT t1.c1, t2.c2 FROM test_partition_table t1 JOIN test_partition_table t2 US
 0 9
 0 10
 
+# left_join_using_qualified (snowflake syntax)
+query error DataFusion error: This feature is not implemented: Invalid identifier in USING clause\. Expected single identifier, got t2\.c2
+SELECT t1.c1, t2.c2 FROM test_partition_table t1 JOIN test_partition_table t2 USING (t2.c2) ORDER BY t2.c2;

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org