You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:26:14 UTC
[GitHub] [skywalking] arugal opened a new pull request #5390: Support in filter expressions in OAL
arugal opened a new pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390
Support `in` expression and fix some question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `13.88%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.00% 39.12% -13.89%
+ Complexity 3218 2310 -908
=============================================
Files 1509 822 -687
Lines 32618 20751 -11867
Branches 3584 2004 -1580
=============================================
- Hits 17290 8118 -9172
+ Misses 14498 12008 -2490
+ Partials 830 625 -205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1123 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `23.10%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 30.11% -23.11%
+ Complexity 3218 1833 -1385
=============================================
Files 830 810 -20
Lines 20940 20267 -673
Branches 2032 1967 -65
=============================================
- Hits 11144 6104 -5040
- Misses 8885 13710 +4825
+ Partials 911 453 -458
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [313 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `70.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 53.12% -0.10%
- Complexity 3218 3219 +1
============================================
Files 830 1510 +680
Lines 20940 32606 +11666
Branches 2032 3590 +1558
============================================
+ Hits 11144 17322 +6178
- Misses 8885 14450 +5565
+ Partials 911 834 -77
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `57.14% <40.00%> (-42.86%)` | `2.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `61.53% <61.53%> (ø)` | `1.00 <1.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `55.55% <71.42%> (+55.55%)` | `0.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `97.59% <100.00%> (+20.96%)` | `26.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [1041 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477356724
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
+
+DOT: '.';
+LR_BRACKET: '(';
+RR_BRACKET: ')';
+LR_SQUARE_BRACKET: '[';
+RR_SQUARE_BRACKET: ']';
Review comment:
Done, you're right :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `70.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.00% 53.10% +0.09%
- Complexity 3218 3223 +5
============================================
Files 1509 1511 +2
Lines 32618 32656 +38
Branches 3584 3589 +5
============================================
+ Hits 17290 17342 +52
+ Misses 14498 14481 -17
- Partials 830 833 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `57.14% <40.00%> (-42.86%)` | `2.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `61.53% <61.53%> (ø)` | `1.00 <1.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `55.55% <71.42%> (-1.59%)` | `0.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `97.59% <100.00%> (+5.38%)` | `26.00 <0.00> (ø)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `25.00% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `83.87% <0.00%> (-3.23%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `12.27%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 40.93% -12.28%
+ Complexity 3218 2392 -826
=============================================
Files 830 826 -4
Lines 20940 20792 -148
Branches 2032 2024 -8
=============================================
- Hits 11144 8512 -2632
- Misses 8885 11643 +2758
+ Partials 911 637 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [178 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477399459
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
Yes confirmed, moving the `like` literally on top of `IDENTIFIER` solves the problem, it WAS treated as an identifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `13.22%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 39.99% -13.23%
+ Complexity 3218 2347 -871
=============================================
Files 830 826 -4
Lines 20940 20789 -151
Branches 2032 2024 -8
=============================================
- Hits 11144 8315 -2829
- Misses 8885 11838 +2953
+ Partials 911 636 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [205 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477360627
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,41 @@
package org.apache.skywalking.oal.rt.parser;
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@Getter
@Setter
@NoArgsConstructor
-@AllArgsConstructor
public class ConditionExpression {
// original from script
private String expressionType;
private String attribute;
private String value;
+ private List<String> values;
Review comment:
The `values` default is`null`, what did I miss?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `53.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 0.00% -53.01%
============================================
Files 1509 160 -1349
Lines 32618 3944 -28674
Branches 3584 463 -3121
============================================
- Hits 17290 0 -17290
+ Misses 14498 3944 -10554
+ Partials 830 0 -830
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1477 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `12.62%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 40.59% -12.63%
+ Complexity 3218 2350 -868
=============================================
Files 830 810 -20
Lines 20940 20366 -574
Branches 2032 1971 -61
=============================================
- Hits 11144 8267 -2877
- Misses 8885 11469 +2584
+ Partials 911 630 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `15.08%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.00% 37.92% -15.09%
+ Complexity 3218 2214 -1004
=============================================
Files 1509 806 -703
Lines 32618 20293 -12325
Branches 3584 1965 -1619
=============================================
- Hits 17290 7696 -9594
+ Misses 14498 11989 -2509
+ Partials 830 608 -222
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1138 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477399459
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
Yes confirmed, moving the `like` exactly on top of `IDENTIFIER` solves the problem, it WAS treated as an identifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support in filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477172347
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java
##########
@@ -23,6 +23,19 @@
@FilterMatcher("stringMatch")
public class EqualMatch {
+
+ public boolean match(String left, String right) {
Review comment:
Yes, passed the unit test.
https://github.com/apache/skywalking/blob/720c1dd92f3883fc8841b0dbbb3508b40a122168/oap-server/oal-rt/src/test/java/org/apache/skywalking/oal/rt/parser/ScriptParserTest.java#L87-L111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477256306
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/LikeMatch.java
##########
@@ -23,14 +23,18 @@
@FilterMatcher
public class LikeMatch {
public boolean match(String left, String right) {
- if (left == null || right == null) {
+ if (right == null || left == null) {
Review comment:
What's the difference
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
+
+DOT: '.';
+LR_BRACKET: '(';
+RR_BRACKET: ')';
+LR_SQUARE_BRACKET: '[';
+RR_SQUARE_BRACKET: ']';
Review comment:
I think the original `LR_BRACKET` means `Left Round Bracket`, so the new one can be simplified `LS_BRACKET`, or if you like `L_SQUARE_BRACKET`
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,41 @@
package org.apache.skywalking.oal.rt.parser;
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@Getter
@Setter
@NoArgsConstructor
-@AllArgsConstructor
public class ConditionExpression {
// original from script
private String expressionType;
private String attribute;
private String value;
+ private List<String> values;
Review comment:
The minimal change is to annotate this field with `@Builder.Default` and give it a default value (`null` for example)
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
I don't see any difference between the `like` expression and others, and can be solved by simply moving these symbols, can you check why it (doesn't) work(s) (before) after moving these?
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/LikeMatch.java
##########
@@ -23,14 +23,18 @@
@FilterMatcher
public class LikeMatch {
public boolean match(String left, String right) {
- if (left == null || right == null) {
+ if (right == null || left == null) {
return false;
}
- if (left.startsWith("%") && left.endsWith("%")) { // %keyword%
- return right.contains(left.substring(1, left.length() - 1));
+ if (right.startsWith("\"") && right.endsWith("\"")) {
+ right = right.substring(1, right.length() - 1);
}
- return (left.startsWith("%") && right.endsWith(left.substring(1))) // %suffix
- || (left.endsWith("%") && right.startsWith(left.substring(0, left.length() - 1))) // prefix%
+
+ if (right.startsWith("%") && right.endsWith("%")) { // %keyword%
+ return left.contains(right.substring(1, right.length() - 1));
Review comment:
OK I made a mistake here before :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 168 -662
Lines 20940 4031 -16909
Branches 2032 470 -1562
============================================
- Hits 11144 0 -11144
+ Misses 8885 4031 -4854
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [788 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 53.04% -0.18%
+ Complexity 3218 3217 -1
============================================
Files 830 831 +1
Lines 20940 20936 -4
Branches 2032 2036 +4
============================================
- Hits 11144 11106 -38
- Misses 8885 8917 +32
- Partials 911 913 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-7.05%)` | `12.00% <0.00%> (ø%)` | |
| [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00% <0.00%> (ø%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `70.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.00% 53.10% +0.09%
- Complexity 3218 3223 +5
============================================
Files 1509 1511 +2
Lines 32618 32656 +38
Branches 3584 3589 +5
============================================
+ Hits 17290 17342 +52
+ Misses 14498 14481 -17
- Partials 830 833 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `57.14% <40.00%> (-42.86%)` | `2.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `61.53% <61.53%> (ø)` | `1.00 <1.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `55.55% <71.42%> (-1.59%)` | `0.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `97.59% <100.00%> (+5.38%)` | `26.00 <0.00> (ø)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `25.00% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `83.87% <0.00%> (-3.23%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477394678
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,41 @@
package org.apache.skywalking.oal.rt.parser;
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@Getter
@Setter
@NoArgsConstructor
-@AllArgsConstructor
public class ConditionExpression {
// original from script
private String expressionType;
private String attribute;
private String value;
+ private List<String> values;
Review comment:
@arugal I think Zhenxu is talking about using Lombok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `2.74%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.26% -2.75%
+ Complexity 3218 3053 -165
============================================
Files 1509 827 -682
Lines 32618 20794 -11824
Branches 3584 2009 -1575
============================================
- Hits 17290 10452 -6838
+ Misses 14498 9457 -5041
- Partials 830 885 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1057 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `22.47%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.12% 30.64% -22.48%
+ Complexity 3216 1859 -1357
=============================================
Files 828 805 -23
Lines 20941 20273 -668
Branches 2032 1967 -65
=============================================
- Hits 11125 6213 -4912
- Misses 8912 13591 +4679
+ Partials 904 469 -435
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [292 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `10.17%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 43.04% -10.18%
+ Complexity 3218 2502 -716
=============================================
Files 830 829 -1
Lines 20940 20841 -99
Branches 2032 2025 -7
=============================================
- Hits 11144 8971 -2173
- Misses 8885 11210 +2325
+ Partials 911 660 -251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [156 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.13% 53.26% +0.12%
- Complexity 3218 3222 +4
============================================
Files 828 827 -1
Lines 20941 20929 -12
Branches 2032 2033 +1
============================================
+ Hits 11127 11147 +20
+ Misses 8910 8869 -41
- Partials 904 913 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `55.17% <0.00%> (-4.60%)` | `13.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `76.31% <0.00%> (-2.64%)` | `16.00% <0.00%> (-2.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477355522
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
> Could your current test case reproduce the error? If these changed back to the old way.
Based on the master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 52.88% -0.33%
+ Complexity 3218 3209 -9
============================================
Files 830 831 +1
Lines 20940 20936 -4
Branches 2032 2036 +4
============================================
- Hits 11144 11073 -71
- Misses 8885 8952 +67
Partials 911 911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-7.05%)` | `12.00% <0.00%> (ø%)` | |
| ... and [13 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `2.23%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 50.97% -2.24%
+ Complexity 3218 3110 -108
============================================
Files 830 826 -4
Lines 20940 20826 -114
Branches 2032 2025 -7
============================================
- Hits 11144 10617 -527
- Misses 8885 9322 +437
+ Partials 911 887 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-85.25%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `12.14%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.00% 40.86% -12.15%
+ Complexity 3218 2390 -828
=============================================
Files 1509 825 -684
Lines 32618 20783 -11835
Branches 3584 2009 -1575
=============================================
- Hits 17290 8493 -8797
+ Misses 14498 11645 -2853
+ Partials 830 645 -185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1116 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `12.21%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.00% 40.79% -12.22%
+ Complexity 3218 2389 -829
=============================================
Files 1509 825 -684
Lines 32618 20783 -11835
Branches 3584 2009 -1575
=============================================
- Hits 17290 8478 -8812
+ Misses 14498 11660 -2838
+ Partials 830 645 -185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1116 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `11.93%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 41.27% -11.94%
+ Complexity 3218 2374 -844
=============================================
Files 830 810 -20
Lines 20940 20366 -574
Branches 2032 1971 -61
=============================================
- Hits 11144 8407 -2737
- Misses 8885 11330 +2445
+ Partials 911 629 -282
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [216 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477177573
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
Please recheck. @arugal Could your current test case reproduce the error? If these changed back to the old way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `20.75%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.13% 32.37% -20.76%
+ Complexity 3218 1970 -1248
=============================================
Files 828 805 -23
Lines 20941 20297 -644
Branches 2032 1968 -64
=============================================
- Hits 11127 6572 -4555
- Misses 8910 13238 +4328
+ Partials 904 487 -417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [279 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support in filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477172393
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
@kezhenxu94, the like expression seems to have some issue when @arugal did local test. He did local tests, so he moved the symbols here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `11.88%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 41.32% -11.89%
+ Complexity 3218 2427 -791
=============================================
Files 830 828 -2
Lines 20940 20816 -124
Branches 2032 2009 -23
=============================================
- Hits 11144 8603 -2541
- Misses 8885 11572 +2687
+ Partials 911 641 -270
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [199 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `53.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 0.00% -53.01%
============================================
Files 1509 164 -1345
Lines 32618 3984 -28634
Branches 3584 465 -3119
============================================
- Hits 17290 0 -17290
+ Misses 14498 3984 -10514
+ Partials 830 0 -830
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1477 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `12.16%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.00% 40.84% -12.17%
+ Complexity 3218 2390 -828
=============================================
Files 1509 827 -682
Lines 32618 20794 -11824
Branches 3584 2009 -1575
=============================================
- Hits 17290 8493 -8797
+ Misses 14498 11656 -2842
+ Partials 830 645 -185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1116 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477173735
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,42 @@
package org.apache.skywalking.oal.rt.parser;
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@Getter
@Setter
@NoArgsConstructor
-@AllArgsConstructor
public class ConditionExpression {
// original from script
private String expressionType;
private String attribute;
private String value;
+
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `18.66%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 34.54% -18.67%
+ Complexity 3218 2053 -1165
=============================================
Files 830 821 -9
Lines 20940 20553 -387
Branches 2032 1974 -58
=============================================
- Hits 11144 7101 -4043
- Misses 8885 12934 +4049
+ Partials 911 518 -393
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `53.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 0.00% -53.01%
============================================
Files 1509 154 -1355
Lines 32618 3812 -28806
Branches 3584 455 -3129
============================================
- Hits 17290 0 -17290
+ Misses 14498 3812 -10686
+ Partials 830 0 -830
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1480 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `21.05%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.12% 32.06% -21.06%
+ Complexity 3216 1957 -1259
=============================================
Files 828 805 -23
Lines 20941 20297 -644
Branches 2032 1968 -64
=============================================
- Hits 11125 6509 -4616
- Misses 8912 13299 +4387
+ Partials 904 489 -415
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [277 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `12.68%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.13% 40.45% -12.69%
+ Complexity 3218 2360 -858
=============================================
Files 828 808 -20
Lines 20941 20421 -520
Branches 2032 1993 -39
=============================================
- Hits 11127 8261 -2866
- Misses 8910 11529 +2619
+ Partials 904 631 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.13% 53.28% +0.14%
- Complexity 3218 3223 +5
============================================
Files 828 827 -1
Lines 20941 20929 -12
Branches 2032 2033 +1
============================================
+ Hits 11127 11151 +24
+ Misses 8910 8865 -45
- Partials 904 913 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `76.31% <0.00%> (-2.64%)` | `16.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <0.00%> (-1.82%)` | `11.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `2.99%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.01% -3.00%
+ Complexity 3218 3054 -164
============================================
Files 1509 830 -679
Lines 32618 20901 -11717
Branches 3584 2035 -1549
============================================
- Hits 17290 10453 -6837
+ Misses 14498 9564 -4934
- Partials 830 884 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1053 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477306063
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
From my understanding, antlr and all word analyzer are order sensitive. It could match the keyword or string before these matches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `2.25%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 50.96% -2.26%
+ Complexity 3218 3109 -109
============================================
Files 830 826 -4
Lines 20940 20826 -114
Branches 2032 2025 -7
============================================
- Hits 11144 10613 -531
- Misses 8885 9326 +441
+ Partials 911 887 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-85.25%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [38 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477381101
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
@kezhenxu94 From my reading of the old OALLexer definition, `like` or `in` could be tagged as `IDENTIFIER`. So when the Parser wants to match the expression, mismatch happens. I don't know whether this is the case, or there is deeper reason for word analysis.
```
expression
: booleanMatch | stringMatch | greaterMatch | lessMatch | greaterEqualMatch | lessEqualMatch | notEqualMatch | booleanNotEqualMatch | likeMatch
;
booleanMatch
: conditionAttribute DUALEQUALS booleanConditionValue
;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `2.48%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 50.73% -2.49%
+ Complexity 3218 3112 -106
============================================
Files 830 831 +1
Lines 20940 20936 -4
Branches 2032 2036 +4
============================================
- Hits 11144 10621 -523
- Misses 8885 9426 +541
+ Partials 911 889 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-85.25%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 154 -676
Lines 20940 3811 -17129
Branches 2032 441 -1591
============================================
- Hits 11144 0 -11144
+ Misses 8885 3811 -5074
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [799 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `49.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 49.49% 0.00% -49.50%
============================================
Files 828 158 -670
Lines 20905 3908 -16997
Branches 2031 452 -1579
============================================
- Hits 10346 0 -10346
+ Misses 9695 3908 -5787
+ Partials 864 0 -864
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [794 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `0.66%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.13% 52.47% -0.67%
+ Complexity 3218 3190 -28
============================================
Files 828 826 -2
Lines 20941 20890 -51
Branches 2032 2032
============================================
- Hits 11127 10961 -166
- Misses 8910 9028 +118
+ Partials 904 901 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| [...plugin/elasticsearch/query/TopologyQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVG9wb2xvZ3lRdWVyeUVzREFPLmphdmE=) | `1.50% <0.00%> (-57.15%)` | `1.00% <0.00%> (-9.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `3.75% <0.00%> (-28.75%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.21% 53.39% +0.18%
- Complexity 3218 3219 +1
============================================
Files 830 829 -1
Lines 20940 20841 -99
Branches 2032 2025 -7
============================================
- Hits 11144 11129 -15
+ Misses 8885 8802 -83
+ Partials 911 910 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-7.05%)` | `12.00% <0.00%> (ø%)` | |
| [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00% <0.00%> (ø%)` | |
| [...nalyzer/provider/meter/process/MeterProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJQcm9jZXNzb3IuamF2YQ==) | `57.62% <0.00%> (-3.39%)` | `13.00% <0.00%> (ø%)` | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `16.95%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 36.26% -16.96%
+ Complexity 3218 2134 -1084
=============================================
Files 830 826 -4
Lines 20940 20616 -324
Branches 2032 1979 -53
=============================================
- Hits 11144 7476 -3668
- Misses 8885 12595 +3710
+ Partials 911 545 -366
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.13% 53.26% +0.13%
- Complexity 3218 3223 +5
============================================
Files 828 828
Lines 20941 20933 -8
Branches 2032 2033 +1
============================================
+ Hits 11127 11151 +24
+ Misses 8910 8869 -41
- Partials 904 913 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `76.31% <0.00%> (-2.64%)` | `16.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <0.00%> (-1.82%)` | `11.00% <0.00%> (ø%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.13% 53.26% +0.13%
- Complexity 3218 3223 +5
============================================
Files 828 828
Lines 20941 20933 -8
Branches 2032 2033 +1
============================================
+ Hits 11127 11151 +24
+ Misses 8910 8869 -41
- Partials 904 913 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `76.31% <0.00%> (-2.64%)` | `16.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <0.00%> (-1.82%)` | `11.00% <0.00%> (ø%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `70.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.00% 53.10% +0.09%
- Complexity 3218 3223 +5
============================================
Files 1509 1511 +2
Lines 32618 32656 +38
Branches 3584 3589 +5
============================================
+ Hits 17290 17342 +52
+ Misses 14498 14481 -17
- Partials 830 833 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `57.14% <40.00%> (-42.86%)` | `2.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `61.53% <61.53%> (ø)` | `1.00 <1.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `55.55% <71.42%> (-1.59%)` | `0.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `97.59% <100.00%> (+5.38%)` | `26.00 <0.00> (ø)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `25.00% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `83.87% <0.00%> (-3.23%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `9.31%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 43.89% -9.32%
+ Complexity 3218 2551 -667
============================================
Files 830 829 -1
Lines 20940 20841 -99
Branches 2032 2025 -7
============================================
- Hits 11144 9149 -1995
- Misses 8885 11022 +2137
+ Partials 911 670 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [146 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `2.83%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.16% -2.84%
+ Complexity 3218 3053 -165
============================================
Files 1509 828 -681
Lines 32618 20834 -11784
Branches 3584 2013 -1571
============================================
- Hits 17290 10452 -6838
+ Misses 14498 9497 -5001
- Partials 830 885 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1057 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 156 -674
Lines 20940 3824 -17116
Branches 2032 442 -1590
============================================
- Hits 11144 0 -11144
+ Misses 8885 3824 -5061
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [798 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `2.42%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.58% -2.43%
+ Complexity 3218 3107 -111
============================================
Files 1509 832 -677
Lines 32618 20978 -11640
Branches 3584 2037 -1547
============================================
- Hits 17290 10611 -6679
+ Misses 14498 9473 -5025
- Partials 830 894 +64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1050 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `25.04%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 28.16% -25.05%
+ Complexity 3218 1697 -1521
=============================================
Files 830 805 -25
Lines 20940 20089 -851
Branches 2032 1934 -98
=============================================
- Hits 11144 5659 -5485
- Misses 8885 14024 +5139
+ Partials 911 406 -505
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [331 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `2.74%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.26% -2.75%
+ Complexity 3218 3053 -165
============================================
Files 1509 827 -682
Lines 32618 20794 -11824
Branches 3584 2009 -1575
============================================
- Hits 17290 10452 -6838
+ Misses 14498 9457 -5041
- Partials 830 885 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1057 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `3.09%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 49.90% -3.10%
+ Complexity 3218 3054 -164
============================================
Files 1509 832 -677
Lines 32618 20944 -11674
Branches 3584 2036 -1548
============================================
- Hits 17290 10453 -6837
+ Misses 14498 9607 -4891
- Partials 830 884 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1052 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477172997
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java
##########
@@ -23,6 +23,19 @@
@FilterMatcher("stringMatch")
public class EqualMatch {
+
+ public boolean match(String left, String right) {
Review comment:
I noticed there are tests, just confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 158 -672
Lines 20940 3864 -17076
Branches 2032 446 -1586
============================================
- Hits 11144 0 -11144
+ Misses 8885 3864 -5021
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [795 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `3.01%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 49.99% -3.02%
+ Complexity 3218 3056 -162
============================================
Files 1509 832 -677
Lines 32618 20944 -11674
Branches 3584 2036 -1548
============================================
- Hits 17290 10470 -6820
+ Misses 14498 9590 -4908
- Partials 830 884 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1052 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477383268
##########
File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4
##########
@@ -61,6 +61,26 @@ SRC_PROFILE_TASK: 'profile_task';
SRC_PROFILE_TASK_LOG: 'profile_task_log';
SRC_PROFILE_THREAD_SHANPSHOT: 'profile_task_segment_snapshot';
+// Constructors symbols
Review comment:
`latency like` could be `IDENTIFIER` + `IDENTIFIER`. That is why when we talked about the language, there is a concept called KEYWORDs, which are not allowed to be used as an IDENTIFIER name, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `2.26%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 50.95% -2.27%
+ Complexity 3218 3110 -108
============================================
Files 830 828 -2
Lines 20940 20837 -103
Branches 2032 2025 -7
============================================
- Hits 11144 10617 -527
- Misses 8885 9333 +448
+ Partials 911 887 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-85.25%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.21% 53.29% +0.08%
+ Complexity 3218 3208 -10
============================================
Files 830 829 -1
Lines 20940 20841 -99
Branches 2032 2025 -7
============================================
- Hits 11144 11108 -36
+ Misses 8885 8825 -60
+ Partials 911 908 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | `39.28% <0.00%> (-10.72%)` | `6.00% <0.00%> (-1.00%)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-7.05%)` | `12.00% <0.00%> (ø%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 154 -676
Lines 20940 3811 -17129
Branches 2032 441 -1591
============================================
- Hits 11144 0 -11144
+ Misses 8885 3811 -5074
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [799 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `2.98%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.02% -2.99%
+ Complexity 3218 3053 -165
============================================
Files 1509 830 -679
Lines 32618 20893 -11725
Branches 3584 2020 -1564
============================================
- Hits 17290 10452 -6838
+ Misses 14498 9556 -4942
- Partials 830 885 +55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1055 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `10.12%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 43.09% -10.13%
+ Complexity 3218 2503 -715
=============================================
Files 830 829 -1
Lines 20940 20841 -99
Branches 2032 2025 -7
=============================================
- Hits 11144 8981 -2163
- Misses 8885 11199 +2314
+ Partials 911 661 -250
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `70.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.00% 53.12% +0.11%
- Complexity 3218 3223 +5
============================================
Files 1509 1510 +1
Lines 32618 32646 +28
Branches 3584 3589 +5
============================================
+ Hits 17290 17342 +52
+ Misses 14498 14471 -27
- Partials 830 833 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `57.14% <40.00%> (-42.86%)` | `2.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `61.53% <61.53%> (ø)` | `1.00 <1.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `55.55% <71.42%> (-1.59%)` | `0.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `97.59% <100.00%> (+5.38%)` | `26.00 <0.00> (ø)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `25.00% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `83.87% <0.00%> (-3.23%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `21.74%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 31.47% -21.75%
+ Complexity 3218 1861 -1357
=============================================
Files 830 805 -25
Lines 20940 20109 -831
Branches 2032 1936 -96
=============================================
- Hits 11144 6330 -4814
- Misses 8885 13327 +4442
+ Partials 911 452 -459
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [303 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `15.15%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.00% 37.85% -15.16%
+ Complexity 3218 2257 -961
=============================================
Files 1509 822 -687
Lines 32618 20737 -11881
Branches 3584 2003 -1581
=============================================
- Hits 17290 7850 -9440
+ Misses 14498 12274 -2224
+ Partials 830 613 -217
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1129 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.21% 53.39% +0.18%
- Complexity 3218 3219 +1
============================================
Files 830 829 -1
Lines 20940 20841 -99
Branches 2032 2025 -7
============================================
- Hits 11144 11129 -15
+ Misses 8885 8802 -83
+ Partials 911 910 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-7.05%)` | `12.00% <0.00%> (ø%)` | |
| [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00% <0.00%> (ø%)` | |
| [...nalyzer/provider/meter/process/MeterProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJQcm9jZXNzb3IuamF2YQ==) | `57.62% <0.00%> (-3.39%)` | `13.00% <0.00%> (ø%)` | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 164 -666
Lines 20940 3978 -16962
Branches 2032 466 -1566
============================================
- Hits 11144 0 -11144
+ Misses 8885 3978 -4907
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [792 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `3.00%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 50.00% -3.01%
+ Complexity 3218 3054 -164
============================================
Files 1509 831 -678
Lines 32618 20905 -11713
Branches 3584 2035 -1549
============================================
- Hits 17290 10453 -6837
+ Misses 14498 9568 -4930
- Partials 830 884 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (-57.15%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-21.13%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1053 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `53.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.00% 0.00% -53.01%
============================================
Files 1509 162 -1347
Lines 32618 3972 -28646
Branches 3584 465 -3119
============================================
- Hits 17290 0 -17290
+ Misses 14498 3972 -10526
+ Partials 830 0 -830
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1477 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...196c84d](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `12.37%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 40.84% -12.38%
+ Complexity 3218 2384 -834
=============================================
Files 830 826 -4
Lines 20940 20792 -148
Branches 2032 2024 -8
=============================================
- Hits 11144 8492 -2652
- Misses 8885 11664 +2779
+ Partials 911 636 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [183 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `70.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.00% 53.12% +0.11%
- Complexity 3218 3223 +5
============================================
Files 1509 1510 +1
Lines 32618 32646 +28
Branches 3584 3589 +5
============================================
+ Hits 17290 17342 +52
+ Misses 14498 14471 -27
- Partials 830 833 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `57.14% <40.00%> (-42.86%)` | `2.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `61.53% <61.53%> (ø)` | `1.00 <1.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `55.55% <71.42%> (-1.59%)` | `0.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `97.59% <100.00%> (+5.38%)` | `26.00 <0.00> (ø)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `57.14% <0.00%> (-42.86%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `25.00% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `83.87% <0.00%> (-3.23%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `26.08%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.12% 27.03% -26.09%
+ Complexity 3216 1657 -1559
=============================================
Files 828 805 -23
Lines 20941 20108 -833
Branches 2032 1937 -95
=============================================
- Hits 11125 5437 -5688
- Misses 8912 14293 +5381
+ Partials 904 378 -526
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [329 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `11.69%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 41.52% -11.70%
+ Complexity 3218 2443 -775
=============================================
Files 830 826 -4
Lines 20940 20826 -114
Branches 2032 2025 -7
=============================================
- Hits 11144 8648 -2496
- Misses 8885 11530 +2645
+ Partials 911 648 -263
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [171 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `20.84%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.13% 32.29% -20.85%
+ Complexity 3218 1970 -1248
=============================================
Files 828 808 -20
Lines 20941 20351 -590
Branches 2032 1975 -57
=============================================
- Hits 11127 6572 -4555
- Misses 8910 13292 +4382
+ Partials 904 487 -417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support in filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477169957
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java
##########
@@ -23,6 +23,19 @@
@FilterMatcher("stringMatch")
public class EqualMatch {
+
+ public boolean match(String left, String right) {
Review comment:
`equal match` support literal string?
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,42 @@
package org.apache.skywalking.oal.rt.parser;
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
@Getter
@Setter
@NoArgsConstructor
-@AllArgsConstructor
public class ConditionExpression {
// original from script
private String expressionType;
private String attribute;
private String value;
+
Review comment:
I think this empty line is not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `20.74%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.12% 32.37% -20.75%
+ Complexity 3216 1970 -1246
=============================================
Files 828 805 -23
Lines 20941 20297 -644
Branches 2032 1968 -64
=============================================
- Hits 11125 6572 -4553
- Misses 8912 13238 +4326
+ Partials 904 487 -417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [279 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `11.60%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.13% 41.52% -11.61%
+ Complexity 3218 2455 -763
=============================================
Files 828 826 -2
Lines 20941 20890 -51
Branches 2032 2032
=============================================
- Hits 11127 8675 -2452
- Misses 8910 11566 +2656
+ Partials 904 649 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 53.04% -0.18%
+ Complexity 3218 3217 -1
============================================
Files 830 831 +1
Lines 20940 20936 -4
Branches 2032 2036 +4
============================================
- Hits 11144 11106 -38
- Misses 8885 8917 +32
- Partials 911 913 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/library/client/jdbc/JDBCClientException.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvSkRCQ0NsaWVudEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (-7.05%)` | `12.00% <0.00%> (ø%)` | |
| [.../analyzer/provider/meter/process/MeterBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvTWV0ZXJCdWlsZGVyLmphdmE=) | `40.62% <0.00%> (-4.69%)` | `7.00% <0.00%> (ø%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
+ Coverage 53.13% 53.28% +0.14%
- Complexity 3218 3223 +5
============================================
Files 828 827 -1
Lines 20941 20929 -12
Branches 2032 2033 +1
============================================
+ Hits 11127 11151 +24
+ Misses 8910 8865 -45
- Partials 904 913 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `76.31% <0.00%> (-2.64%)` | `16.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <0.00%> (-1.82%)` | `11.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/086d730aedd9d9b37d3dc2d9b15f3de2b1fa378b?el=desc) will **decrease** coverage by `49.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 49.49% 0.00% -49.50%
============================================
Files 828 154 -674
Lines 20905 3811 -17094
Branches 2031 441 -1590
============================================
- Hits 10346 0 -10346
+ Misses 9695 3811 -5884
+ Partials 864 0 -864
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [797 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [086d730...1037cfa](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 168 -662
Lines 20940 4031 -16909
Branches 2032 470 -1562
============================================
- Hits 11144 0 -11144
+ Misses 8885 4031 -4854
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [788 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 51.47% -1.75%
+ Complexity 3218 3141 -77
============================================
Files 830 831 +1
Lines 20940 20936 -4
Branches 2032 2036 +4
============================================
- Hits 11144 10777 -367
- Misses 8885 9259 +374
+ Partials 911 900 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-85.25%)` | `0.00% <0.00%> (-9.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 162 -668
Lines 20940 3966 -16974
Branches 2032 466 -1566
============================================
- Hits 11144 0 -11144
+ Misses 8885 3966 -4919
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [792 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `11.11%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
=============================================
- Coverage 53.21% 42.10% -11.12%
+ Complexity 3218 2454 -764
=============================================
Files 830 828 -2
Lines 20940 20828 -112
Branches 2032 2012 -20
=============================================
- Hits 11144 8769 -2375
- Misses 8885 11401 +2516
+ Partials 911 658 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `2.46%`.
> The diff coverage is `7.31%`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 50.75% -2.47%
+ Complexity 3218 3112 -106
============================================
Files 830 831 +1
Lines 20940 20928 -12
Branches 2032 2036 +4
============================================
- Hits 11144 10621 -523
- Misses 8885 9418 +533
+ Partials 911 889 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `28.57% <0.00%> (-71.43%)` | `2.00 <0.00> (ø)` | |
| [...rver/core/analysis/metrics/expression/InMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0luTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `71.08% <14.28%> (-5.54%)` | `26.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `15.38% <15.38%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-85.25%)` | `0.00% <0.00%> (-9.00%)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5390: Support IN filter expressions in OAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#issuecomment-680783958
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=h1) Report
> Merging [#5390](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/720c1dd92f3883fc8841b0dbbb3508b40a122168?el=desc) will **decrease** coverage by `53.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5390 +/- ##
============================================
- Coverage 53.21% 0.00% -53.22%
============================================
Files 830 166 -664
Lines 20940 3989 -16951
Branches 2032 466 -1566
============================================
- Hits 11144 0 -11144
+ Misses 8885 3989 -4896
+ Partials 911 0 -911
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [790 more](https://codecov.io/gh/apache/skywalking/pull/5390/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=footer). Last update [720c1dd...f8ab6fc](https://codecov.io/gh/apache/skywalking/pull/5390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org