You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/17 08:56:33 UTC

[GitHub] [iotdb] SilverNarcissus commented on a change in pull request #5267: [IOTDB-2754] SessionPool auto redirect IoTDB instance

SilverNarcissus commented on a change in pull request #5267:
URL: https://github.com/apache/iotdb/pull/5267#discussion_r828883641



##########
File path: example/session/src/main/java/org/apache/iotdb/SessionPoolExample.java
##########
@@ -32,31 +32,54 @@
 
 public class SessionPoolExample {
 
-  private static SessionPool pool;
+  private static SessionPool customSessionPool;
+  private static SessionPool redirectSessionPool;
   private static ExecutorService service;
 
   public static void main(String[] args)
       throws StatementExecutionException, IoTDBConnectionException, InterruptedException {
-    pool =
+    // Custom SessionPool

Review comment:
       We should avoid commented code in example




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org