You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/09 18:44:06 UTC
[GitHub] [incubator-yunikorn-k8shim] craigcondit opened a new pull request #383: [YUNIKORN-1111] Run yunikorn as non-root user (shim)
craigcondit opened a new pull request #383:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/383
### What is this PR for?
Updates the docker images for YuniKorn to run as a non-root user. This increases security as we do not really need root access.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1111
### How should this be tested?
Local e2e tests continue to pass, and locally verified that containers run as non-root.
### Screenshots (if appropriate)
Scheduler:
<img width="793" alt="scheduler-non-root" src="https://user-images.githubusercontent.com/12699633/157509692-35be23c1-51ad-4049-9461-abe333b4364f.png">
Scheduler plugin:
<img width="802" alt="plugin-non-root" src="https://user-images.githubusercontent.com/12699633/157509712-c9e844c5-8923-4687-bb2d-bdb1d1f569fb.png">
Admission controller:
<img width="844" alt="admission-non-root" src="https://user-images.githubusercontent.com/12699633/157509722-00683480-0ac9-4fca-9d1f-f670ea350194.png">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit closed pull request #383: [YUNIKORN-1111] Run yunikorn as non-root user (shim)
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #383:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #383: [YUNIKORN-1111] Run yunikorn as non-root user (shim)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #383:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/383#issuecomment-1063254341
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#383](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97c61fd) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/816a5f470ff5b04cb1cfa68df820b8392992b022?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (816a5f4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 41 41
Lines 6267 6267
=======================================
Hits 4067 4067
Misses 2044 2044
Partials 156 156
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [816a5f4...97c61fd](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #383: [YUNIKORN-1111] Run yunikorn as non-root user (shim)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #383:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/383#issuecomment-1063254341
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#383](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97c61fd) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/816a5f470ff5b04cb1cfa68df820b8392992b022?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (816a5f4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 41 41
Lines 6267 6267
=======================================
Hits 4067 4067
Misses 2044 2044
Partials 156 156
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [816a5f4...97c61fd](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/383?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #383: [YUNIKORN-1111] Run yunikorn as non-root user (shim)
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #383:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/383#issuecomment-1063352009
Re-running tests just to confirm this plays nicely with https://issues.apache.org/jira/browse/YUNIKORN-997.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org