about Bug 57701

[Fernando Boaglio <bo...@gmail.com>]

Hello,

I have some thoughts about Mark's comments (
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701#c3 ) and I would
like to discuss it here =)

> I'm not convinced of the need for this feature but I don't object to it being added.
> Overall the patch looks good. There is the odd s/reload/redploy/ required but that looks like copy/paste errors and is easily fixed.

I thought redeploy was another option and not a replacement for reload .
Is this assumption correct ?

> I'm more concerned that the actual redeploy code is not correct.
> The issues I could see from a code inspection (I haven't tried applying the patch) are:
>  - it assumes that the web application is deployed as a WAR
Correct, if is not a WAR, the reload option should be enough.

> - it assumes autoDeployment is enabled
I don't know.

>  - it doesn't mark the web application as being serviced
I don't know either. Sorry =(

> I'd expect to see the following:
> - the context marked as serviced
> - the context removed from the host
> - check() being used to redeploy it
> - the serviced mark removed from the host

What is the main reason for the check method, the source says "Invoke
the check method on the deployer", but I'm not sure what it really
does.

Same thing to the serviced methods.

Can someone give me a hint please ? =)

-- 
[]'s
Fernando Boaglio

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org