You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/24 10:08:44 UTC
[GitHub] [iceberg] yittg opened a new pull request #3956: Close resources in catalog properly
yittg opened a new pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956
Some resources in catalog are not closed properly, this change normalize the close of catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#discussion_r791403599
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -76,7 +76,7 @@
* objects stored in them to assist with namespace-centric catalog exploration.
* </p>
*/
-public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable {
+public class NessieCatalog extends BaseMetastoreCatalog implements SupportsNamespaces, Configurable {
Review comment:
yep that seems ok, thanks for the ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] yittg commented on pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
yittg commented on pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#issuecomment-1031037142
ping @rdblue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#discussion_r791065949
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -76,7 +76,7 @@
* objects stored in them to assist with namespace-centric catalog exploration.
* </p>
*/
-public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable {
+public class NessieCatalog extends BaseMetastoreCatalog implements SupportsNamespaces, Configurable {
Review comment:
@nastra and @rymurr, is this change okay for Nessie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
nastra commented on pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#issuecomment-1061849558
@rdblue shall we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] yittg commented on a change in pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
yittg commented on a change in pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#discussion_r791287038
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -76,7 +76,7 @@
* objects stored in them to assist with namespace-centric catalog exploration.
* </p>
*/
-public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable {
+public class NessieCatalog extends BaseMetastoreCatalog implements SupportsNamespaces, Configurable {
Review comment:
Thanks @rdblue for helping ping, i think it's equivalent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#discussion_r791403599
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -76,7 +76,7 @@
* objects stored in them to assist with namespace-centric catalog exploration.
* </p>
*/
-public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable {
+public class NessieCatalog extends BaseMetastoreCatalog implements SupportsNamespaces, Configurable {
Review comment:
yep that seems ok, thanks for the ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#discussion_r791065949
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -76,7 +76,7 @@
* objects stored in them to assist with namespace-centric catalog exploration.
* </p>
*/
-public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable {
+public class NessieCatalog extends BaseMetastoreCatalog implements SupportsNamespaces, Configurable {
Review comment:
@nastra and @rymurr, is this change okay for Nessie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] yittg commented on a change in pull request #3956: Close resources in catalog properly
Posted by GitBox <gi...@apache.org>.
yittg commented on a change in pull request #3956:
URL: https://github.com/apache/iceberg/pull/3956#discussion_r791287038
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -76,7 +76,7 @@
* objects stored in them to assist with namespace-centric catalog exploration.
* </p>
*/
-public class NessieCatalog extends BaseMetastoreCatalog implements AutoCloseable, SupportsNamespaces, Configurable {
+public class NessieCatalog extends BaseMetastoreCatalog implements SupportsNamespaces, Configurable {
Review comment:
Thanks @rdblue for helping ping, i think it's equivalent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org