[GitHub] [lucene-solr] dsmiley commented on issue #887: SOLR-13773: Prometheus Exporter GC and Heap options

[GitBox <gi...@apache.org>]

dsmiley commented on issue #887: SOLR-13773: Prometheus Exporter GC and Heap options
URL: https://github.com/apache/lucene-solr/pull/887#issuecomment-532375530
 
 
   I'm doubtful that we should use environment variables called SOLR_HEAP or SOLR_JAVA_MEM because because here the scope of use is not Solr (possibly a beefy well provisioned process), it's instead some light-weight side-car container.  Maybe just JAVA_HEAP and JAVA_MEM?  
   
   Aside: I wish all Java/JVM based containers standardized the naming and semantics of such env variables, and perhaps be a bit generic referring to only "JAVA" or "JVM".  It's confusing to remember which ones apply to Kafka vs Solr vs whatever.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org