You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jwitko (via GitHub)" <gi...@apache.org> on 2023/02/03 03:55:34 UTC
[GitHub] [druid] jwitko opened a new pull request, #13746: helm: Stop helm chart from failing if zkHosts is not set
jwitko opened a new pull request, #13746:
URL: https://github.com/apache/druid/pull/13746
Fixes #13745
### Description
If a user deploying via the Apache Druid helm chart is while using `druid-kubernetes-extensions` then there is no need to set a zookeeper host however the helm chart will fail if the user does not.
This change will remove the requirement for setting a zookeeper host and adds a comment to the values file to help helm chart consumers understand.
### Alternatives
An alternative design could have been to look for the druid config settings required [in the documentation](https://druid.apache.org/docs/latest/development/extensions-core/kubernetes.html) and base the conditional off of those but since they can be set at a per-process or global config level I thought it better to keep it simple.
#### Release note
Fixed: Helm chart no longer requires a ZooKeeper host be set for users using `druid-kubernetes-extensions`
This PR has:
- [X] been self-reviewed.
- [X] added documentation for new or modified features or behaviors.
- [X] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #13746:
URL: https://github.com/apache/druid/pull/13746#issuecomment-1422027035
Thank you @jwitko for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dampcake commented on a diff in pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "dampcake (via GitHub)" <gi...@apache.org>.
dampcake commented on code in PR #13746:
URL: https://github.com/apache/druid/pull/13746#discussion_r1096020082
##########
helm/druid/templates/configmap.yaml:
##########
@@ -31,7 +31,7 @@ data:
{{ toYaml .Values.configVars | indent 2 }}
{{- if .Values.zookeeper.enabled }}
druid_zk_service_host: {{ .Release.Name }}-zookeeper-headless:2181
-{{- else }}
+{{- else .Values.zkHosts }}
Review Comment:
Pretty sure this should be:
```suggestion
{{- else if .Values.zkHosts }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] a2l007 commented on pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "a2l007 (via GitHub)" <gi...@apache.org>.
a2l007 commented on PR #13746:
URL: https://github.com/apache/druid/pull/13746#issuecomment-1421148966
> > @jwitko Thanks, Going forward please avoid rebasing and force pushing for commits after submitting the PR, since this makes it harder for the reviewers to see what has changed between commits.
>
> sure no problem. what is preferred? `git merge upstream/master` ?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jwitko commented on a diff in pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on code in PR #13746:
URL: https://github.com/apache/druid/pull/13746#discussion_r1096023324
##########
helm/druid/templates/configmap.yaml:
##########
@@ -31,7 +31,7 @@ data:
{{ toYaml .Values.configVars | indent 2 }}
{{- if .Values.zookeeper.enabled }}
druid_zk_service_host: {{ .Release.Name }}-zookeeper-headless:2181
-{{- else }}
+{{- else .Values.zkHosts }}
Review Comment:
Ugh, yes I thought I had that. Thank you for catching. Will fix now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jwitko commented on pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on PR #13746:
URL: https://github.com/apache/druid/pull/13746#issuecomment-1420933752
> @jwitko - can you pull the changes from the master branch? That might fix the build failures.
@abhishekagarwal87 I have rebased and should be up to date with the upstream master branch. Once this is merged I'll do the same to #13747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] a2l007 commented on pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "a2l007 (via GitHub)" <gi...@apache.org>.
a2l007 commented on PR #13746:
URL: https://github.com/apache/druid/pull/13746#issuecomment-1421096202
@jwitko Thanks, Going forward please avoid rebasing and force pushing for commits after submitting the PR, since this makes it harder for the reviewers to see what has changed between commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13746:
URL: https://github.com/apache/druid/pull/13746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #13746:
URL: https://github.com/apache/druid/pull/13746#issuecomment-1420437618
@jwitko - can you pull the changes from the master branch? That might fix the build failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jwitko commented on pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on PR #13746:
URL: https://github.com/apache/druid/pull/13746#issuecomment-1421098426
> @jwitko Thanks, Going forward please avoid rebasing and force pushing for commits after submitting the PR, since this makes it harder for the reviewers to see what has changed between commits.
sure no problem. what is preferred? `git merge upstream/master` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jwitko commented on a diff in pull request #13746: helm: Stop helm chart from failing if zkHosts is not set
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on code in PR #13746:
URL: https://github.com/apache/druid/pull/13746#discussion_r1096024975
##########
helm/druid/templates/configmap.yaml:
##########
@@ -31,7 +31,7 @@ data:
{{ toYaml .Values.configVars | indent 2 }}
{{- if .Values.zookeeper.enabled }}
druid_zk_service_host: {{ .Release.Name }}-zookeeper-headless:2181
-{{- else }}
+{{- else .Values.zkHosts }}
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org