You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Victor Ionescu (JIRA)" <ji...@apache.org> on 2011/01/26 14:23:43 UTC

[jira] Created: (WICKET-3391) Extensibility of the Wizard component

Extensibility of the Wizard component
-------------------------------------

                 Key: WICKET-3391
                 URL: https://issues.apache.org/jira/browse/WICKET-3391
             Project: Wicket
          Issue Type: Improvement
          Components: wicket-extensions
    Affects Versions: 1.4.15
         Environment: All
            Reporter: Victor Ionescu


The Wizard component  org.apache.wicket.extensions.wizard is hard to utilize due to the following issues:
-  the signature of the method 
protected FeedbackPanel newFeedbackPanel(String id)
is too restricive. It could be modified into
protected Component  newFeedbackPanel(String id)
This way programmers could plug in their own custom feedback panels (as in my case).

- the constructor of the class org.apache.wicket.extensions.wizard.WizardButtonBar:
public WizardButtonBar(String id, Wizard wizard)
should be refactored into
public WizardButtonBar(String id, IWizard wizard)
for obvious design reasons.






-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3391) Extensibility of the Wizard component

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994077#comment-12994077 ] 

Hudson commented on WICKET-3391:
--------------------------------

Integrated in Apache Wicket 1.4.x #436 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/436/])
    WICKET-3391 Extensibility of the Wizard component

Make Wizard components more extensible


> Extensibility of the Wizard component
> -------------------------------------
>
>                 Key: WICKET-3391
>                 URL: https://issues.apache.org/jira/browse/WICKET-3391
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.15
>         Environment: All
>            Reporter: Victor Ionescu
>            Assignee: Martin Grigorov
>             Fix For: 1.4.16, 1.5-RC2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The Wizard component  org.apache.wicket.extensions.wizard is hard to utilize due to the following issues:
> -  the signature of the method 
> protected FeedbackPanel newFeedbackPanel(String id)
> is too restricive. It could be modified into
> protected Component  newFeedbackPanel(String id)
> This way programmers could plug in their own custom feedback panels (as in my case).
> - the constructor of the class org.apache.wicket.extensions.wizard.WizardButtonBar:
> public WizardButtonBar(String id, Wizard wizard)
> should be refactored into
> public WizardButtonBar(String id, IWizard wizard)
> for obvious design reasons.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (WICKET-3391) Extensibility of the Wizard component

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3391.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC2
                   1.4.16
         Assignee: Martin Grigorov

Improved with r1070213 (trunk) and 1070212 (1.4.x).

> Extensibility of the Wizard component
> -------------------------------------
>
>                 Key: WICKET-3391
>                 URL: https://issues.apache.org/jira/browse/WICKET-3391
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.15
>         Environment: All
>            Reporter: Victor Ionescu
>            Assignee: Martin Grigorov
>             Fix For: 1.4.16, 1.5-RC2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The Wizard component  org.apache.wicket.extensions.wizard is hard to utilize due to the following issues:
> -  the signature of the method 
> protected FeedbackPanel newFeedbackPanel(String id)
> is too restricive. It could be modified into
> protected Component  newFeedbackPanel(String id)
> This way programmers could plug in their own custom feedback panels (as in my case).
> - the constructor of the class org.apache.wicket.extensions.wizard.WizardButtonBar:
> public WizardButtonBar(String id, Wizard wizard)
> should be refactored into
> public WizardButtonBar(String id, IWizard wizard)
> for obvious design reasons.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira