You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/07 22:43:35 UTC
Review Request 16703: saving timestamp state to local storage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16703/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
saving timestamp state to local storage
toggling globally on click
toggle timestamp type by clicking on it
converting all instances of timestamps over to the directive
working on moving timestamps into a directive
Diffs
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16703/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16703: saving timestamp state to local storage
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16703/#review31312
-----------------------------------------------------------
src/webui/master/static/directives/timestamp.html
<https://reviews.apache.org/r/16703/#comment59771>
How do you feel about nuking this Flash object clipboard thing? With the addition of toggling, the one-click copy seems unnecessary. And that Flash directive is expensive to render.
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16703/#comment59773>
Can you inject $window into the link function to add it as a known dependency? Angular exposes the global `window` as a service `$window`.
- Ross Allen
On Jan. 7, 2014, 9:46 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16703/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 9:46 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16703/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16703: saving timestamp state to local storage
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16703/#review31310
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16703/#comment59770>
Could this instead be the contents of the 'mTimestamp.toggle' event handler? That would prevent needing access to $rootScope.
- Ross Allen
On Jan. 7, 2014, 9:46 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16703/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 9:46 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16703/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16703: saving timestamp state to local storage
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16703/#review31315
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16703/#comment59775>
Which case did this catch? Were invalid dates being passed to these functions?
- Ross Allen
On Jan. 7, 2014, 9:46 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16703/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 9:46 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will make timestamps toggle between relative and absolute values (for easy cut/paste).
>
> Issue: https://issues.apache.org/jira/browse/MESOS-789
>
>
> Diffs
> -----
>
> src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
> src/webui/master/static/directives/timestamp.html PRE-CREATION
> src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
> src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
> src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
> src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
> src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
> src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
> src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
>
> Diff: https://reviews.apache.org/r/16703/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16703: saving timestamp state to local storage
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16703/
-----------------------------------------------------------
(Updated Jan. 7, 2014, 9:46 p.m.)
Review request for mesos.
Repository: mesos-git
Description (updated)
-------
This will make timestamps toggle between relative and absolute values (for easy cut/paste).
Issue: https://issues.apache.org/jira/browse/MESOS-789
Diffs
-----
src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d
src/webui/master/static/directives/timestamp.html PRE-CREATION
src/webui/master/static/framework.html 7dc620509829125a487ed1021638ae5a10ed62e0
src/webui/master/static/frameworks.html f83cffea5fb5f32c4a4690d7548aa784a6d21e67
src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717
src/webui/master/static/index.html a5833f65b5d19319c4a91277e1d328241c9b7806
src/webui/master/static/js/app.js 79778503bf77cbdba6725e4140c81cc5f1a70462
src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257
src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7
Diff: https://reviews.apache.org/r/16703/diff/
Testing
-------
Thanks,
Thomas Rampelberg