You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/20 04:40:26 UTC

[GitHub] [skywalking-java] nisiyong commented on pull request #389: Compatible with 3.x and 4.x RabbitMQ Connection

nisiyong commented on PR #389:
URL: https://github.com/apache/skywalking-java/pull/389#issuecomment-1321037527

   The previous test case used `com.rabbitmq.client.DeliverCallback` introduced in 5.0.0,  and if we tested with 3.x or 4.x, it will fail to compile.
   Now the case uses the old way of consuming messages, which is compatible with versions from 3.0.0 to 5.16.0. 
   * https://mvnrepository.com/artifact/com.rabbitmq/amqp-client
   
   I also wanna rename `rabbitmq-5.x-plugin` to `rabbitmq-plugin`. What do you think about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org