You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2011/11/18 01:03:51 UTC
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152479#comment-13152479 ]
Hadoop QA commented on HADOOP-7833:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504144/HADOOP-7833.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/382//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/382//console
This message is automatically generated.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira