[GitHub] ivankelly opened a new pull request #990: Fix tight loop in getFileInfo

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #990: Fix tight loop in getFileInfo
URL: https://github.com/apache/bookkeeper/pull/990
 
 
   The argument to assertions is not evaluated if assertions is disabled,
   which was messing up the refcounting for the fileinfo backing
   cache. We ended up with dead fileinfo objects in the guava caches,
   which triggered an infinite loop.
   
   This patch fixes that by moving the tryRetain() out of the assert. It
   also adds defensive code to getFileInfo to ensure that if a fileinfo
   object is dead, that it doesn't exist any longer in the caches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services