You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "tm-drtina (via GitHub)" <gi...@apache.org> on 2023/11/29 00:41:42 UTC
[PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]
tm-drtina opened a new pull request, #425:
URL: https://github.com/apache/directory-scimple/pull/425
https://issues.apache.org/jira/browse/SCIMPLE-93
Fields that have `referenceTypes` set should have type `reference`. Previously we set type=reference for field `type`, but it should be on field `ref`
```
{
"name" : "value",
"type" : "reference",
"referenceTypes" : ["external"],
"multiValued" : false,
"description" : "URL of a photo of the User.",
"required" : false,
"caseExact" : false,
"mutability" : "readWrite",
"returned" : "default",
"uniqueness" : "none"
},
```
source: https://datatracker.ietf.org/doc/html/rfc7643#section-8.7.1 (page 59)
> A reference has a "referenceTypes" attribute...
> ...
> By convention, a reference is commonly represented as a "$ref" sub-attribute in complex or multi-valued attributes; however, this is OPTIONAL.
source: https://datatracker.ietf.org/doc/html/rfc7643#section-2.3.7
The condition is not very nice, since the default is a list with one empty string...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #425:
URL: https://github.com/apache/directory-scimple/pull/425#issuecomment-1832116765
This is great! Thanks @tm-drtina!
Any ideas for a test or two? If you don't have time to implement them, that's understandable, but a little pseudo code, will help too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]
Posted by "tm-drtina (via GitHub)" <gi...@apache.org>.
tm-drtina commented on PR #425:
URL: https://github.com/apache/directory-scimple/pull/425#issuecomment-1832147195
I saw there were some tests for schema: https://github.com/apache/directory-scimple/blob/develop/scim-spec/scim-spec-schema/src/test/java/org/apache/directory/scim/spec/schema/SchemaTest.java
But I think the simplest one would be to query `/v2/Schemas` and compare the result with the static jsons, which are already in the test resources. It's been a while since I last used in Java, but I can take a look :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #425:
URL: https://github.com/apache/directory-scimple/pull/425#issuecomment-1858610801
Fixed in: #452
Thanks again @tm-drtina! this was really helpful and me track down a related issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers closed pull request #425: [SCIMPLE-93] Set type=reference, when referenceTypes are set
URL: https://github.com/apache/directory-scimple/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org