[jira] [Closed] (OFBIZ-6631) Optimize ShoppingCart.removeCartItem (skip price calc and inventory check)

["Michael Brohl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-6631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-6631.
--------------------------------
       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   Release Branch 13.07
                   Release Branch 14.12
                   Upcoming Branch

Fixed in
trunk r1704000
release branch 14.12 r1704001
release branch 13.07 r1704002
release branch 12.04 r1704003

Thanks Martin!

> Optimize ShoppingCart.removeCartItem (skip price calc and inventory check)
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-6631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6631
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Upcoming Branch
>            Reporter: Martin Becker
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Branch, Release Branch 14.12, Release Branch 13.07, Release Branch 12.04
>
>         Attachments: OFBIZ-6631-Optimized-RemoveCartItem.patch
>
>
> Based on the standard parameter completion from the overloaded API of ShoppingCartItem.setQuantity, the use of the ShoppingCart.removeCartItem method leads to an unnecessary price calculation and inventory check for the item being removed.
> By using the setQuantity method with full parameter list in this case, this can be avoided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)