[GitHub] [pinot] amrishlal commented on a diff in pull request #9312: [Feature] Support IsDistinctFrom and IsNotDistinctFrom

[GitBox <gi...@apache.org>]

amrishlal commented on code in PR #9312:
URL: https://github.com/apache/pinot/pull/9312#discussion_r965336457


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##########
@@ -168,4 +168,18 @@ public void testCaseWithNotNullDescription()
     String query = "SELECT CASE WHEN description IS NOT NULL THEN 1 ELSE 0 END FROM " + getTableName();
     testQuery(query);
   }
+
+  @Test
+  public void testCaseWithIsDistinctFrom()
+      throws Exception {
+    String query = "SELECT salary IS DISTINCT FROM salary FROM " + getTableName();

Review Comment:
   Can we get a couple more test cases using "IS [NOT] DISTINCT FROM" operator over expressions and in where clause?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org