You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/11/15 00:45:28 UTC

[GitHub] [incubator-yunikorn-k8shim] manirajv06 commented on a change in pull request #321: YUNIKORN-906: Shim side changes of YUNIKORN-337

manirajv06 commented on a change in pull request #321:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/321#discussion_r748942411



##########
File path: pkg/cache/node.go
##########
@@ -149,10 +149,13 @@ func (n *SchedulerNode) handleNodeRecovery(event *fsm.Event) {
 		zap.String("nodeID", n.name),
 		zap.Bool("schedulable", n.schedulable))
 
-	request := &si.UpdateRequest{
+	allocRequest := &si.AllocationRequest{
 		Asks:     nil,
 		Releases: nil,
-		NewSchedulableNodes: []*si.NewNodeInfo{
+		RmID:     conf.GetSchedulerConf().ClusterID,
+	}

Review comment:
       Just retained those request params as it was there before. Removed the same now. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org