[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238564#comment-16238564 ] 

Hadoop QA commented on PHOENIX-2048:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12883121/PHOENIX-2048_v2.patch
  against master branch at commit a09cea6bfb94edd95ce06aa2cb7f229227db5666.
  ATTACHMENT ID: 12883121

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1618//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1618//console

This message is automatically generated.

> change to_char() function to use HALF_UP rounding mode
> ------------------------------------------------------
>
>                 Key: PHOENIX-2048
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2048
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: verify
>            Reporter: Jonathan Leech
>            Assignee: Csaba Skrabak
>            Priority: Minor
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-2048.patch, PHOENIX-2048_v2.patch
>
>
> to_char() function uses the default rounding mode in java DecimalFormat, which is a strange one called HALF_EVEN, which rounds a '5' in the last position either up or down depending on the preceding digit. 
> Change it to HALF_UP so it rounds the same way as the round() function does, or provide a way to override the behavior; e.g. globally or as a client config, or an argument to the to_char() function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)