You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/10/28 18:13:18 UTC
Maven/checkstyle changes
Hey, what changed in the Maven setup regarding checkstyle?
I used to be able to run "mvn validate" to run checkstyle to find
style violations up front (e.g., before starting a long test run).
However, that doesn't seem to work any more. It looks like checkstyle
is run later, but it's not clear in what Maven phase or step.
How do we run checkstyle (without building everything) now?
Thanks,
Daniel
--
Daniel Barclay
MapR Technologies
Re: Maven/checkstyle changes
Posted by Julien Le Dem <ju...@dremio.com>.
... of:
https://github.com/apache/drill/pull/221
On Wed, Oct 28, 2015 at 10:50 AM, Julien Le Dem <ju...@dremio.com> wrote:
> Daniel,
> If you move the config for the checkstyle plugin out of the executions
> tag, you can run mvn checkstyle:check
> See:
>
> https://github.com/apache/drill/commit/eefbaa448ab15974d5e63cf37615ce20bb436ba2
> It'll be part of:
>
> On Wed, Oct 28, 2015 at 10:37 AM, Julien Le Dem <ju...@dremio.com> wrote:
>
>> Hi Daniel,
>> I moved checkstyle to the verify phase that comes after the tests and
>> before package:
>>
>> https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
>> This is the default binding for checkstyle:
>> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html
>> This has been part of the modifications to speedup the build.
>> mvn test should be as fast as possible.
>> I think rat should be moved to verify as well as it slows down running
>> tests (especially if you're running a single one)
>>
>>
>>
>> On Wed, Oct 28, 2015 at 10:13 AM, Daniel Barclay <db...@maprtech.com>
>> wrote:
>>
>>> Hey, what changed in the Maven setup regarding checkstyle?
>>>
>>> I used to be able to run "mvn validate" to run checkstyle to find
>>> style violations up front (e.g., before starting a long test run).
>>>
>>> However, that doesn't seem to work any more. It looks like checkstyle
>>> is run later, but it's not clear in what Maven phase or step.
>>>
>>>
>>> How do we run checkstyle (without building everything) now?
>>>
>>> Thanks,
>>> Daniel
>>> --
>>> Daniel Barclay
>>> MapR Technologies
>>>
>>
>>
>>
>> --
>> Julien
>>
>
>
>
> --
> Julien
>
--
Julien
Re: Maven/checkstyle changes
Posted by Julien Le Dem <ju...@dremio.com>.
Daniel,
If you move the config for the checkstyle plugin out of the executions tag,
you can run mvn checkstyle:check
See:
https://github.com/apache/drill/commit/eefbaa448ab15974d5e63cf37615ce20bb436ba2
It'll be part of:
On Wed, Oct 28, 2015 at 10:37 AM, Julien Le Dem <ju...@dremio.com> wrote:
> Hi Daniel,
> I moved checkstyle to the verify phase that comes after the tests and
> before package:
>
> https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
> This is the default binding for checkstyle:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html
> This has been part of the modifications to speedup the build.
> mvn test should be as fast as possible.
> I think rat should be moved to verify as well as it slows down running
> tests (especially if you're running a single one)
>
>
>
> On Wed, Oct 28, 2015 at 10:13 AM, Daniel Barclay <db...@maprtech.com>
> wrote:
>
>> Hey, what changed in the Maven setup regarding checkstyle?
>>
>> I used to be able to run "mvn validate" to run checkstyle to find
>> style violations up front (e.g., before starting a long test run).
>>
>> However, that doesn't seem to work any more. It looks like checkstyle
>> is run later, but it's not clear in what Maven phase or step.
>>
>>
>> How do we run checkstyle (without building everything) now?
>>
>> Thanks,
>> Daniel
>> --
>> Daniel Barclay
>> MapR Technologies
>>
>
>
>
> --
> Julien
>
--
Julien
Re: Maven/checkstyle changes
Posted by Julien Le Dem <ju...@dremio.com>.
Hi Daniel,
I moved checkstyle to the verify phase that comes after the tests and
before package:
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
This is the default binding for checkstyle:
https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html
This has been part of the modifications to speedup the build.
mvn test should be as fast as possible.
I think rat should be moved to verify as well as it slows down running
tests (especially if you're running a single one)
On Wed, Oct 28, 2015 at 10:13 AM, Daniel Barclay <db...@maprtech.com>
wrote:
> Hey, what changed in the Maven setup regarding checkstyle?
>
> I used to be able to run "mvn validate" to run checkstyle to find
> style violations up front (e.g., before starting a long test run).
>
> However, that doesn't seem to work any more. It looks like checkstyle
> is run later, but it's not clear in what Maven phase or step.
>
>
> How do we run checkstyle (without building everything) now?
>
> Thanks,
> Daniel
> --
> Daniel Barclay
> MapR Technologies
>
--
Julien