You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/01 16:19:27 UTC
[jira] [Commented] (FLINK-2748) Accumulator fetch failure leads to
duplicate job result response
[ https://issues.apache.org/jira/browse/FLINK-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939880#comment-14939880 ]
ASF GitHub Bot commented on FLINK-2748:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1206
[FLINK-2748] accumulator fetch failure leads to duplicate job result response
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-2748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1206
----
commit 26e805fe1a3baff9f121a7c7f261b17546d68f80
Author: Maximilian Michels <mx...@apache.org>
Date: 2015-10-01T14:16:11Z
[FLINK-2748] accumulator fetch failure leads to duplicate job result response
----
> Accumulator fetch failure leads to duplicate job result response
> ----------------------------------------------------------------
>
> Key: FLINK-2748
> URL: https://issues.apache.org/jira/browse/FLINK-2748
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: master
> Reporter: Ufuk Celebi
> Assignee: Maximilian Michels
>
> On {{JobStatusChanged}} message and a failure to catch the accumulator result the client will receive a {{JobResultFailure}} and {{JobResultSuccess}} response
> {code}
> newJobStatus match {
> case JobStatus.FINISHED =>
> val accumulatorResults: java.util.Map[String, SerializedValue[AnyRef]] = try {
> executionGraph.getAccumulatorsSerialized()
> } catch {
> case e: Exception =>
> log.error(s"Cannot fetch final accumulators for job $jobID", e)
> val exception = new JobExecutionException(jobID,
> "Failed to retrieve accumulator results.", e)
> jobInfo.client ! decorateMessage(JobResultFailure(
> new SerializedThrowable(exception)))
> Collections.emptyMap() <<< HERE
> }
> val result = new SerializedJobExecutionResult(
> jobID,
> jobInfo.duration,
> accumulatorResults)
> jobInfo.client ! decorateMessage(JobResultSuccess(result)) <<< HERE
> {code}
> Furthermore the indentation is off.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)