[GitHub] [lucene] romseygeek commented on a change in pull request #152: LUCENE 9204: Move SpanQuery and subclasses to the queries module

[GitBox <gi...@apache.org>]

romseygeek commented on a change in pull request #152:
URL: https://github.com/apache/lucene/pull/152#discussion_r638803873



##########
File path: lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java
##########
@@ -457,40 +455,6 @@ public void testBooleanOptionalWithTiebreakerAndBoost() throws Exception {
     }
   }
 
-  // LUCENE-4477 / LUCENE-4401:

Review comment:
       Moved to TestBasics

##########
File path: lucene/core/src/test/org/apache/lucene/search/TestBooleanQuery.java
##########
@@ -386,41 +382,6 @@ public void testBS2DisjunctionNextVsAdvance() throws Exception {
     d.close();
   }
 
-  // LUCENE-4477 / LUCENE-4401:

Review comment:
       Moved to spans/TestBasics

##########
File path: lucene/core/src/test/org/apache/lucene/search/TestComplexExplanations.java
##########
@@ -43,126 +40,6 @@ public void tearDown() throws Exception {
     super.tearDown();
   }
 
-  public void test1() throws Exception {

Review comment:
       These have all moved to TestSpanExplanations

##########
File path: lucene/core/src/test/org/apache/lucene/search/TestPositionIncrement.java
##########
@@ -189,106 +177,4 @@ public void reset() throws IOException {
     reader.close();
     store.close();
   }
-

Review comment:
       Moved to TestPayloadSpanPositions

##########
File path: lucene/core/src/test/org/apache/lucene/search/TestQueryVisitor.java
##########
@@ -56,15 +53,6 @@
                       .build(),
                   3),
               BooleanClause.Occur.MUST)

Review comment:
       Moved to TestSpanQueryVisitor

##########
File path: lucene/core/src/test/org/apache/lucene/search/TestMatchesIterator.java
##########
@@ -443,37 +439,6 @@ public void testExactMultiPhraseQuery() throws IOException {
   //  0         1         2         3         4         5         6         7
   // "a phrase sentence with many phrase sentence iterations of a phrase sentence",
 
-  public void testSpanQuery() throws IOException {

Review comment:
       Moved to TestSpanMatches

##########
File path: lucene/core/src/test/org/apache/lucene/search/TestQueryRescorer.java
##########
@@ -185,18 +182,6 @@ public void testBasic() throws Exception {
     assertEquals("1", searcher.doc(hits2.scoreDocs[0].doc).get("id"));
     assertEquals("0", searcher.doc(hits2.scoreDocs[1].doc).get("id"));
 
-    // Resort using SpanNearQuery:

Review comment:
       Moved to TestQueryRescorerWithSpans

##########
File path: lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java
##########
@@ -268,33 +265,4 @@ public void testOmitTFAndNorms() throws Exception {
     ir.close();
     dir.close();
   }
-

Review comment:
       Moved to TestSpanSimilarity




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org