You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/29 07:03:39 UTC

[GitHub] [shardingsphere] ReyYang commented on a change in pull request #14399: For 14352: Fix the problem of "Sharding value must implements Comparabl" during incremental migration of PostgreSQL

ReyYang commented on a change in pull request #14399:
URL: https://github.com/apache/shardingsphere/pull/14399#discussion_r776179362



##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/WalEventConverter.java
##########
@@ -125,7 +125,11 @@ private DataRecord createDataRecord(final AbstractRowEvent rowsEvent, final int
     
     private void putColumnsIntoDataRecord(final DataRecord dataRecord, final TableMetaData tableMetaData, final List<Object> values) {

Review comment:
       Tested insert and delete have not been affected




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org