You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/06/20 21:44:23 UTC
Review Request 70912: Removed const ref lifetime extension use in
`slave::state::recover`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70912/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Removed const ref lifetime extension use in `slave::state::recover`.
Diffs
-----
src/slave/state.cpp b4bf6292eb482f4e99a27442af0ea03e31c1ddc2
Diff: https://reviews.apache.org/r/70912/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70912: Removed const ref lifetime extension use in
`slave::state::recover`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70912/#review216032
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70822, 70839, 70834, 70835, 70836, 70899, 70900, 70901, 70903, 70904, 70912]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 20, 2019, 2:44 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70912/
> -----------------------------------------------------------
>
> (Updated June 20, 2019, 2:44 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed const ref lifetime extension use in `slave::state::recover`.
>
>
> Diffs
> -----
>
> src/slave/state.cpp b4bf6292eb482f4e99a27442af0ea03e31c1ddc2
>
>
> Diff: https://reviews.apache.org/r/70912/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70912: Removed const ref lifetime extension use in
`slave::state::recover`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70912/#review216139
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On June 20, 2019, 9:44 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70912/
> -----------------------------------------------------------
>
> (Updated June 20, 2019, 9:44 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed const ref lifetime extension use in `slave::state::recover`.
>
>
> Diffs
> -----
>
> src/slave/state.cpp b4bf6292eb482f4e99a27442af0ea03e31c1ddc2
>
>
> Diff: https://reviews.apache.org/r/70912/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>