You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/03 16:25:50 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #6869: Support for parameter `cidrlist` added to the UI
JoaoJandre opened a new pull request, #6869:
URL: https://github.com/apache/cloudstack/pull/6869
### Description
This PR adds the `cidrlist` parameter to the create load balancer rule UI.
This PR also fixes the `BulkActionView.vue`, which currently throws an exception when used.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
This was tested in a local lab, by running `npm run serve` and creating/deleting load balancer rules with `cidrlists`. The BulkActionView was also tested, as before this change it threw an exception and didn't open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1307349646
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1359392952
Merging this one based on the approvals and build result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1332297633
@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1332305767
UI build: :heavy_multiplication_x:
(SL-JID-2652)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1333930800
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1302367250
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1357703252
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6869: Support for parameter `cidrlist` added to the UI
URL: https://github.com/apache/cloudstack/pull/6869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1357710646
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6869 (QA-JID-19)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1333930403
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1333949557
UI build: :heavy_multiplication_x:
(SL-JID-2655)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1376942875
@GutoVeronezi
thanks, good to know. no worries, bugs could happen.
I have a suggestion: If any of you have tested a PR, can you comment the PR that you have tested it, for example "manually tested ok" ? It would be much better if test steps and results are added as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1375517356
> @GutoVeronezi @JoaoJandre @stephankruggg Do you have QA engineer or mutually review/testing process ?
@weizhouapache, yes, we have a process; however, as you may know by personal experience, sometimes some use cases are missed. Thanks for fixing the regression, we will pay more attention in next PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1357704210
@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi merged pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
GutoVeronezi merged PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1372157954
@GutoVeronezi @JoaoJandre @stephankruggg
Do you have QA engineer or mutually review/testing process ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1307348414
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1302368887
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6869: Support for parameter `cidrlist` added to the UI
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1302444272
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6869](https://codecov.io/gh/apache/cloudstack/pull/6869?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (504e267) into [main](https://codecov.io/gh/apache/cloudstack/commit/fa39e61a4ccd33ccb9b81481eb57c64b3adaf6f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa39e61) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6869 +/- ##
=========================================
Coverage 10.84% 10.85%
- Complexity 7104 7106 +2
=========================================
Files 2485 2485
Lines 245417 245417
Branches 38326 38326
=========================================
+ Hits 26627 26631 +4
+ Misses 215521 215516 -5
- Partials 3269 3270 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6869/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org