[GitHub] [incubator-kyuubi] bowenliang123 commented on a diff in pull request #3983: [KYUUBI #3982] [FEATURE] introduce reloading server config without restart

[GitBox <gi...@apache.org>]

bowenliang123 commented on code in PR #3983:
URL: https://github.com/apache/incubator-kyuubi/pull/3983#discussion_r1049256540


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -105,6 +105,10 @@ object KyuubiServer extends Logging {
     val _hadoopConf = KyuubiHadoopUtils.newHadoopConf(new KyuubiConf().loadFileDefaults())
     hadoopConf = _hadoopConf
   }
+
+  private[kyuubi] def reloadServerConf(): Unit = synchronized {
+    kyuubiServer.conf.loadFileDefaults()

Review Comment:
   @turboFei @pan3793 
   Have a look at this PR if you have time.
   It's reusing the `loadFileDefaults` method to read the config file  `kyuubi-defaults.conf` and overriding server configs. And if any configs not in the config file are set during runtime, they won't be affected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org