You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/17 15:40:52 UTC

[GitHub] [nifi] YolandaMDavis commented on pull request #4323: NIFI-7516: Catch and log SingularMatrixExceptions in OrdinaryLeastSquares model

YolandaMDavis commented on pull request #4323:
URL: https://github.com/apache/nifi/pull/4323#issuecomment-645452929


   @mattyb149  I ran through tests for this which included confirming that predictions worked as expected (for a growing queue) and confirming that exceptions are not thrown for queues that have contents, yet do not change.  I was unable to create an exact scenario however given the code you have in place if an exception is caught and logged when a score retrieval is attempted, the score would return as null and it would indicate the model is invalid which I believe is fine.
   
   +1.  Once CI tests pass successfully I will merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org