You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "ashishksdev (via GitHub)" <gi...@apache.org> on 2025/10/28 15:47:36 UTC
[PR] Add blog content to separate blogs branch (#2774) [polaris]
ashishksdev opened a new pull request, #2926:
URL: https://github.com/apache/polaris/pull/2926
This PR adds the site/content/blog content to the blogs branch as requested in #2774.
### Does this PR introduce any user-facing change?
No — this moves documentation content to the designated branch.
### How was this patch tested?
The blog folder site/content/blog was copied from the upstream main branch and committed to this blogs branch. Folder structure was verified.
### CHANGELOG.md
Not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2926:
URL: https://github.com/apache/polaris/pull/2926#issuecomment-3462484631
@ashishksdev : I commented on the issue: https://github.com/apache/polaris/issues/2774#issuecomment-3462481275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2470174832
##########
site/content/blog/2025/08/20/apache-polaris-1.0.1-incubating.md:
##########
@@ -17,23 +17,25 @@
# specific language governing permissions and limitations
# under the License.
#
-title: Getting Started with Apache Polaris
-linkTitle: Getting Started
-type: docs
-weight: 101
+title: Apache Polaris 1.0.1-incubating has been released!
Review Comment:
In fact, it should not be necessary to change existing blog files, I think. If the `blogs` branch is created from `main`, it should already have all the blog files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "ashishksdev (via GitHub)" <gi...@apache.org>.
ashishksdev commented on PR #2926:
URL: https://github.com/apache/polaris/pull/2926#issuecomment-3467804077
Thanks for the feedback and discussion on this PR!
After reviewing the concerns raised, I realize this PR has several issues:
1. Author information being unintentionally changed (as @dimas-b pointed out)
2. Files showing as modifications instead of clean additions/deletions
3. Cleanup of irrelevant files already in blogs (as it is based on versioned-docs) and addition of site/content/blog is in single PR, making it difficult to review
I'm going to close this PR and propose a cleaner approach:
My proposed plan:
- PR #1: Remove all existing content from the blogs branch (as @dimas-b preferred)
- PR #2: Add the blog content (2025 folder and _index.adoc) directly to the blogs branch, preserving original author information
This keeps changes separated and cleaner for review.
Questions before I proceed:
1. Does this two-PR approach work for you, or would you prefer a different workflow?
2. What's the correct Git method to preserve author information when moving the blog content? Should I use git cherry-pick or another approach?
3. Should I wait for the CI discussion to conclude first, or can I proceed with clearing/adding the blog content now?
Please let me know if you have any suggestions or a different approach in mind. Happy to follow whatever works best!
@flyrain @dimas-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2470149198
##########
0.9.0/_index.md:
##########
Review Comment:
I'd prefer to delete (irrelevant) doc files in a separate PR for the sake of clarity.
##########
site/content/blog/2025/08/20/apache-polaris-1.0.1-incubating.md:
##########
@@ -17,23 +17,25 @@
# specific language governing permissions and limitations
# under the License.
#
-title: Getting Started with Apache Polaris
-linkTitle: Getting Started
-type: docs
-weight: 101
+title: Apache Polaris 1.0.1-incubating has been released!
Review Comment:
Why is this changing when we just "move" blogs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "ashishksdev (via GitHub)" <gi...@apache.org>.
ashishksdev closed pull request #2926: Add blog content to separate blogs branch (#2774)
URL: https://github.com/apache/polaris/pull/2926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2475546929
##########
site/content/blog/2025/08/20/apache-polaris-1.0.1-incubating.md:
##########
@@ -17,23 +17,25 @@
# specific language governing permissions and limitations
# under the License.
#
-title: Getting Started with Apache Polaris
-linkTitle: Getting Started
-type: docs
-weight: 101
+title: Apache Polaris 1.0.1-incubating has been released!
Review Comment:
Github messed up when it generates diffs. It's a new file, instead of changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2475551735
##########
1.0.0/polaris-catalog-service.md:
##########
@@ -17,10 +17,15 @@
# specific language governing permissions and limitations
# under the License.
#
-linkTitle: 'Catalog API Spec'
Review Comment:
Another example of weird diffs generated by Github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "ashishksdev (via GitHub)" <gi...@apache.org>.
ashishksdev commented on PR #2926:
URL: https://github.com/apache/polaris/pull/2926#issuecomment-3462095638
Thanks for the feedback @dimas-b
I understand the CI changes should come first.
Regarding the file changes - I branched off from upstream/blogs (which was created from versioned-docs, not main). I removed the existing files and added the blog content from main, as requested by @flyrain in issue #2774.
I notice the PR is showing some files as "modified" (with red/green changes) when they should just show as "deleted". These are files from the old versioned-docs content - I'm not sure why Git is showing them as modifications instead of clean deletions. The actual blog content I'm adding is just the site/content/blog folder.
A few questions on next steps:
1. Should I wait for the CI changes to be completed before proceeding, or would you like me to fix the Git tracking issue now?
2. Regarding the doc file deletion mentioned - if this PR continues, should I remove that change and handle it in a separate PR?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2474282760
##########
site/content/blog/2025/09/15/doris-polaris-integration.md:
##########
@@ -0,0 +1,427 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+title: "Doris X Polaris: Building Unified Data Lakehouse with Iceberg REST Catalog - A Practical Guide"
+date: 2025-09-15
+author: zy-kkk
Review Comment:
This PR alters git author associations for existing blogs. I believe this should be avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #2926:
URL: https://github.com/apache/polaris/pull/2926#issuecomment-3462622436
Thanks a lot for working on it, @ashishksdev ! As I mentioned here https://github.com/apache/polaris/issues/2774#issuecomment-3462571462, this PR is good as the first PR to add blog content to the new branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #2926:
URL: https://github.com/apache/polaris/pull/2926#issuecomment-3462632423
Do we need directory structure `site/content/blog/*`? We might remove that, and use the year directory(`2025`) directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2475555291
##########
1.0.0/polaris-catalog-service.md:
##########
@@ -17,10 +17,15 @@
# specific language governing permissions and limitations
# under the License.
#
-linkTitle: 'Catalog API Spec'
Review Comment:
Another weird diffs. Should be just a new file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #2926:
URL: https://github.com/apache/polaris/pull/2926#discussion_r2475551735
##########
1.0.0/polaris-catalog-service.md:
##########
@@ -17,10 +17,15 @@
# specific language governing permissions and limitations
# under the License.
#
-linkTitle: 'Catalog API Spec'
Review Comment:
Another example of weird diffs generated by Github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add blog content to separate blogs branch (#2774) [polaris]
Posted by "ashishksdev (via GitHub)" <gi...@apache.org>.
ashishksdev commented on PR #2926:
URL: https://github.com/apache/polaris/pull/2926#issuecomment-3462052290
Thanks for the feedback! I understand the CI changes should come first.
Regarding the file changes - I branched off from upstream/blogs (which was created from versioned-docs, not main). I removed the existing files and added the blog content from main, as requested by @flyrain in issue #2774
I notice the PR is showing some files as "modified" (with red/green changes) when they should just show as "deleted". These are files from the old versioned-docs content - I'm not sure why Git is showing them as modifications instead of clean deletions. The actual blog content I'm adding is just the site/content/blog folder.
A few questions on next steps:
1. Should I wait for the CI changes to be completed before proceeding, or would you like me to fix the Git tracking issue now?
2. Regarding the doc file deletion mentioned - if this PR continues, should I remove that change and handle it in a separate PR?
Happy to adjust however works best for you!
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org