You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Robert Scholte <rf...@apache.org> on 2017/02/18 12:45:14 UTC
Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
I've added a unittest, just to be sure.
Not sure about the price of flushing, but seems expensive to do it after
every write of a single byte.
Robert
On Sat, 18 Feb 2017 08:41:54 +0100, <ti...@apache.org> wrote:
> Author: tibordigana
> Date: Sat Feb 18 07:41:54 2017
> New Revision: 1783494
>
> URL: http://svn.apache.org/viewvc?rev=1783494&view=rev
> Log:
> [MSHARED-617] (FreeBSD) StreamFeeder.java should flush OutputStream
>
> Modified:
> maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
>
> Modified:
> maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
> URL:
> http://svn.apache.org/viewvc/maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java?rev=1783494&r1=1783493&r2=1783494&view=diff
> ==============================================================================
> ---
> maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
> (original)
> +++
> maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
> Sat Feb 18 07:41:54 2017
> @@ -125,6 +125,7 @@ class StreamFeeder
> if ( !isDisabled() )
> {
> os.write( data );
> + os.flush();
> }
> }
> }
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1783494 -
/maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
Posted by Tibor Digana <ti...@apache.org>.
yes, PrintStream, but we have OutputStream which does not flush like
PrintStream.
Nevertheless, I found we implement FlushReceiver which allows me to flush
entire word. This fix flushed a byte. So we perform better in Surefire with
flushed word and maybe we would not need to have this fix in Utils.
I am going to wait for Michael's test results. Until that I will fix two
issues:
+ synchronization/semaphore between ForkedClient/received stream and
ForkStarter
+ drain std buffer.
On Sun, Feb 19, 2017 at 4:44 AM, Hervé BOUTEMY [via Maven] <
ml-node+s40175n5899203h33@n5.nabble.com> wrote:
> notice: on PrintStream, autoflush does such flush only when newline is
> appended
>
> see https://docs.oracle.com/javase/7/docs/api/java/io/
> PrintStream.html#PrintStream(java.io.OutputStream,%20boolean)
>
> Regards,
>
> Hervé
>
> Le samedi 18 février 2017, 13:45:14 CET Robert Scholte a écrit :
>
> > I've added a unittest, just to be sure.
> > Not sure about the price of flushing, but seems expensive to do it after
> > every write of a single byte.
> >
> > Robert
> >
> > On Sat, 18 Feb 2017 08:41:54 +0100, <[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5899203&i=0>> wrote:
> > > Author: tibordigana
> > > Date: Sat Feb 18 07:41:54 2017
> > > New Revision: 1783494
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1783494&view=rev
> > > Log:
> > > [MSHARED-617] (FreeBSD) StreamFeeder.java should flush OutputStream
> > >
> > > Modified:
> > > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apach
>
> > > e/maven/shared/utils/cli/StreamFeeder.java>
> > > Modified:
> > > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/ma
>
> > > ven/shared/utils/cli/StreamFeeder.java URL:
> > > http://svn.apache.org/viewvc/maven/shared/branches/maven-
> shared-utils-0.9.
> > > x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java?rev=17
>
> > > 83494&r1=1783493&r2=1783494&view=diff
> > > =========================================================================
>
> > > ===== ---
> > > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/ma
>
> > > ven/shared/utils/cli/StreamFeeder.java (original)
> > > +++
> > > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/ma
>
> > > ven/shared/utils/cli/StreamFeeder.java Sat Feb 18 07:41:54 2017
> > > @@ -125,6 +125,7 @@ class StreamFeeder
> > >
> > > if ( !isDisabled() )
> > > {
> > >
> > > os.write( data );
> > >
> > > + os.flush();
> > >
> > > }
> > >
> > > }
> > >
> > > }
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5899203&i=1>
> > For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5899203&i=2>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5899203&i=3>
> For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5899203&i=4>
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/Re-svn-commit-r1783494-
> maven-shared-branches-maven-shared-utils-0-9-x-src-main-
> java-org-apache-mavena-tp5899087p5899203.html
> To start a new topic under Maven Developers, email
> ml-node+s40175n142166h86@n5.nabble.com
> To unsubscribe from Maven Developers, click here
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==>
> .
> NAML
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
View this message in context: http://maven.40175.n5.nabble.com/Re-svn-commit-r1783494-maven-shared-branches-maven-shared-utils-0-9-x-src-main-java-org-apache-mavena-tp5899087p5899267.html
Sent from the Maven Developers mailing list archive at Nabble.com.
Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
Posted by Hervé BOUTEMY <he...@free.fr>.
notice: on PrintStream, autoflush does such flush only when newline is appended
see https://docs.oracle.com/javase/7/docs/api/java/io/
PrintStream.html#PrintStream(java.io.OutputStream,%20boolean)
Regards,
Hervé
Le samedi 18 février 2017, 13:45:14 CET Robert Scholte a écrit :
> I've added a unittest, just to be sure.
> Not sure about the price of flushing, but seems expensive to do it after
> every write of a single byte.
>
> Robert
>
> On Sat, 18 Feb 2017 08:41:54 +0100, <ti...@apache.org> wrote:
> > Author: tibordigana
> > Date: Sat Feb 18 07:41:54 2017
> > New Revision: 1783494
> >
> > URL: http://svn.apache.org/viewvc?rev=1783494&view=rev
> > Log:
> > [MSHARED-617] (FreeBSD) StreamFeeder.java should flush OutputStream
> >
> > Modified:
> > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apach
> > e/maven/shared/utils/cli/StreamFeeder.java>
> > Modified:
> > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/ma
> > ven/shared/utils/cli/StreamFeeder.java URL:
> > http://svn.apache.org/viewvc/maven/shared/branches/maven-shared-utils-0.9.
> > x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java?rev=17
> > 83494&r1=1783493&r2=1783494&view=diff
> > =========================================================================
> > ===== ---
> > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/ma
> > ven/shared/utils/cli/StreamFeeder.java (original)
> > +++
> > maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/ma
> > ven/shared/utils/cli/StreamFeeder.java Sat Feb 18 07:41:54 2017
> > @@ -125,6 +125,7 @@ class StreamFeeder
> >
> > if ( !isDisabled() )
> > {
> >
> > os.write( data );
> >
> > + os.flush();
> >
> > }
> >
> > }
> >
> > }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org