You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Julien Le Dem <ju...@ledem.net> on 2012/06/18 20:07:16 UTC
Re: Review Request: Pig creates too many instances of Load and Store Funcs.
It should be 1 in the front-end and 1 in the backend
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5159/
-----------------------------------------------------------
(Updated June 18, 2012, 6:07 p.m.)
Review request for pig.
Changes
-------
change signature in helper method for consistency
Description
-------
Pig creates too many instances of Load and Store Funcs. It should be 1 in the front-end and 1 in the backend
This addresses bug PIG-2699.
https://issues.apache.org/jira/browse/PIG-2699
Diffs (updated)
-----
/trunk/src/org/apache/pig/PigServer.java 1339793
/trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java 1339793
/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1339793
/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStore.java 1339793
/trunk/src/org/apache/pig/newplan/logical/relational/LOLoad.java 1339793
/trunk/src/org/apache/pig/newplan/logical/relational/LOStore.java 1339793
/trunk/src/org/apache/pig/newplan/logical/relational/LogToPhyTranslationVisitor.java 1339793
/trunk/src/org/apache/pig/newplan/logical/rules/LoadStoreFuncDupSignatureValidator.java 1339793
/trunk/src/org/apache/pig/newplan/logical/rules/PartitionFilterOptimizer.java 1339793
/trunk/src/org/apache/pig/newplan/logical/rules/TypeCastInserter.java 1339793
/trunk/src/org/apache/pig/newplan/logical/visitor/ScalarVisitor.java 1339793
/trunk/src/org/apache/pig/parser/FunctionType.java 1339793
/trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java 1339793
/trunk/src/org/apache/pig/parser/QueryParserUtils.java 1339793
/trunk/test/org/apache/pig/TestLoadStoreFuncLifeCycle.java PRE-CREATION
/trunk/test/org/apache/pig/newplan/logical/relational/LOTestHelper.java PRE-CREATION
/trunk/test/org/apache/pig/parser/TestScalarVisitor.java 1339793
/trunk/test/org/apache/pig/test/TestInputOutputFileValidator.java 1339793
/trunk/test/org/apache/pig/test/TestLogToPhyCompiler.java 1339793
/trunk/test/org/apache/pig/test/TestLogicalPlanBuilder.java 1339793
/trunk/test/org/apache/pig/test/TestMRCompiler.java 1339793
/trunk/test/org/apache/pig/test/TestNewPlanFilterRule.java 1339793
/trunk/test/org/apache/pig/test/TestNewPlanListener.java 1339793
/trunk/test/org/apache/pig/test/TestNewPlanLogicalOptimizer.java 1339793
/trunk/test/org/apache/pig/test/TestNewPlanOperatorPlan.java 1339793
/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java 1339793
/trunk/test/org/apache/pig/test/Util.java 1339793
/trunk/test/org/apache/pig/test/utils/TypeCheckingTestUtil.java 1339793
Diff: https://reviews.apache.org/r/5159/diff/
Testing
-------
test-commit + new test
Thanks,
Julien Le Dem
Re: Review Request: Pig creates too many instances of Load and Store Funcs. It should be 1 in the front-end and 1 in the backend
Posted by Julien Le Dem <ju...@twitter.com>.
This is changing a little bit how the signature for Load and Store funcs get generated. This should not be a problem.
I'm going to check it in soon.
Julien
On Jun 18, 2012, at 11:51 AM, Jonathan Coveney wrote:
> Pig gave a ship it? Or do you still need more eyes?
>
> 2012/6/18 Julien Le Dem <ju...@ledem.net>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5159/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:07 p.m.)
>
>
> Review request for pig.
>
>
> Changes
> -------
>
> change signature in helper method for consistency
>
>
> Description
> -------
>
> Pig creates too many instances of Load and Store Funcs. It should be 1 in the front-end and 1 in the backend
>
>
> This addresses bug PIG-2699.
> https://issues.apache.org/jira/browse/PIG-2699
>
>
> Diffs (updated)
> -----
>
> /trunk/src/org/apache/pig/PigServer.java 1339793
> /trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java 1339793
> /trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1339793
> /trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStore.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/relational/LOLoad.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/relational/LOStore.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/relational/LogToPhyTranslationVisitor.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/rules/LoadStoreFuncDupSignatureValidator.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/rules/PartitionFilterOptimizer.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/rules/TypeCastInserter.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/visitor/ScalarVisitor.java 1339793
> /trunk/src/org/apache/pig/parser/FunctionType.java 1339793
> /trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java 1339793
> /trunk/src/org/apache/pig/parser/QueryParserUtils.java 1339793
> /trunk/test/org/apache/pig/TestLoadStoreFuncLifeCycle.java PRE-CREATION
> /trunk/test/org/apache/pig/newplan/logical/relational/LOTestHelper.java PRE-CREATION
> /trunk/test/org/apache/pig/parser/TestScalarVisitor.java 1339793
> /trunk/test/org/apache/pig/test/TestInputOutputFileValidator.java 1339793
> /trunk/test/org/apache/pig/test/TestLogToPhyCompiler.java 1339793
> /trunk/test/org/apache/pig/test/TestLogicalPlanBuilder.java 1339793
> /trunk/test/org/apache/pig/test/TestMRCompiler.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanFilterRule.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanListener.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanLogicalOptimizer.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanOperatorPlan.java 1339793
> /trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java 1339793
> /trunk/test/org/apache/pig/test/Util.java 1339793
> /trunk/test/org/apache/pig/test/utils/TypeCheckingTestUtil.java 1339793
>
> Diff: https://reviews.apache.org/r/5159/diff/
>
>
> Testing
> -------
>
> test-commit + new test
>
>
> Thanks,
>
> Julien Le Dem
>
>
Re: Review Request: Pig creates too many instances of Load and Store
Funcs. It should be 1 in the front-end and 1 in the backend
Posted by Jonathan Coveney <jc...@gmail.com>.
Pig gave a ship it? Or do you still need more eyes?
2012/6/18 Julien Le Dem <ju...@ledem.net>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5159/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:07 p.m.)
>
>
> Review request for pig.
>
>
> Changes
> -------
>
> change signature in helper method for consistency
>
>
> Description
> -------
>
> Pig creates too many instances of Load and Store Funcs. It should be 1 in
> the front-end and 1 in the backend
>
>
> This addresses bug PIG-2699.
> https://issues.apache.org/jira/browse/PIG-2699
>
>
> Diffs (updated)
> -----
>
> /trunk/src/org/apache/pig/PigServer.java 1339793
> /trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java
> 1339793
> /trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java
> 1339793
> /trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStore.java
> 1339793
> /trunk/src/org/apache/pig/newplan/logical/relational/LOLoad.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/relational/LOStore.java 1339793
> /trunk/src/org/apache/pig/newplan/logical/relational/LogToPhyTranslationVisitor.java
> 1339793
> /trunk/src/org/apache/pig/newplan/logical/rules/LoadStoreFuncDupSignatureValidator.java
> 1339793
> /trunk/src/org/apache/pig/newplan/logical/rules/PartitionFilterOptimizer.java
> 1339793
> /trunk/src/org/apache/pig/newplan/logical/rules/TypeCastInserter.java
> 1339793
> /trunk/src/org/apache/pig/newplan/logical/visitor/ScalarVisitor.java
> 1339793
> /trunk/src/org/apache/pig/parser/FunctionType.java 1339793
> /trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java 1339793
> /trunk/src/org/apache/pig/parser/QueryParserUtils.java 1339793
> /trunk/test/org/apache/pig/TestLoadStoreFuncLifeCycle.java PRE-CREATION
> /trunk/test/org/apache/pig/newplan/logical/relational/LOTestHelper.java
> PRE-CREATION
> /trunk/test/org/apache/pig/parser/TestScalarVisitor.java 1339793
> /trunk/test/org/apache/pig/test/TestInputOutputFileValidator.java 1339793
> /trunk/test/org/apache/pig/test/TestLogToPhyCompiler.java 1339793
> /trunk/test/org/apache/pig/test/TestLogicalPlanBuilder.java 1339793
> /trunk/test/org/apache/pig/test/TestMRCompiler.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanFilterRule.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanListener.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanLogicalOptimizer.java 1339793
> /trunk/test/org/apache/pig/test/TestNewPlanOperatorPlan.java 1339793
> /trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
> 1339793
> /trunk/test/org/apache/pig/test/Util.java 1339793
> /trunk/test/org/apache/pig/test/utils/TypeCheckingTestUtil.java 1339793
>
> Diff: https://reviews.apache.org/r/5159/diff/
>
>
> Testing
> -------
>
> test-commit + new test
>
>
> Thanks,
>
> Julien Le Dem
>
>