You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2021/07/30 10:20:00 UTC

[jira] [Commented] (SLING-10689) Extends file must not always generate a Requires-Capability header

    [ https://issues.apache.org/jira/browse/SLING-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390475#comment-17390475 ] 

Konrad Windszus commented on SLING-10689:
-----------------------------------------

I am thinking about using [OSGiHeader.parse(String)|https://github.com/bndtools/bnd/blob/00318682629ab3d4ebaa17917ace9b2eab37e171/biz.aQute.bndlib/src/aQute/bnd/header/OSGiHeader.java#L20] for the {{requires}} file line, to support more parameters than just version (i.e. attributes or directives, compare with http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.common.header.syntax) without relying on the order. The only drawback is that the parser is less lenient, i.e. it would require proper quoting of the version value e.g. in https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/master/src/test/resources/mvn/project-1/src/main/scripts/org.apache.sling.foobar/extends.
[~radu] WDYT?

> Extends file must not always generate a Requires-Capability header
> ------------------------------------------------------------------
>
>                 Key: SLING-10689
>                 URL: https://issues.apache.org/jira/browse/SLING-10689
>             Project: Sling
>          Issue Type: Improvement
>          Components: Maven Plugins and Archetypes
>    Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The  {{extends}} file is necessary for bundled scripts as this generates the {{extends}} attribute of the {{sling.servlet}} capability (which is the only way to express inheritance). Currently the scriptingbundle-maven-plugin always also generates an according {{Require-Capability}} header (https://sling.apache.org/components/scriptingbundle-maven-plugin/). The latter can only be resolved in case the script it extends from is provided as bundled script as well, but not if it is a regular resource script. Therefore there must be an option in the extends file to not generate the Require-Capability header.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)