[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #218: Test pr

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091218


##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
         # contexts are the names of checks that must pass
         contexts:
           - Code is formatted
+    temp:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Check headers

Review Comment:
   We have plenty of work to still do with adding headers - I'd prefer not to make the header check something that completely blocks merges. Humans need to approve PRs anyway. Can we wait till we have added headers everywhere we need them?
   * probably conf files
   * markdown files
   * probably more file types too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org