You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Edmund Wong <ed...@kdtc.net> on 2009/04/08 05:00:10 UTC

[PATCH] Completed TODO: svn_stream_copy3()

Hi,

I'm not even sure it should be labeled as a patch, more
like a RFC rather.  Here's my attempt to close the TODO
for svn_stream_copy3() in stream.c in which the function
"should close the streams ALWAYS, even on error exit".
Since this isn't even a confirmed patch, I haven't made
any modifications to the original comment in svn_io.h.
After this patch has been accepted, then I (or someone)
can remove the TODO.   This is my first C patch.  Talk
about apprehension.

Log:

[[[
       Completed the TODO as stated in svn_io.h for
    svn_stream_copy3().

    * subversion/libsvn_subr/stream.c
      (svn_stream_copy3): Even on error exit, the two files
                          from and to are closed.

     Patch by: Edmund Wong <ed...@belfordhk.com>

]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1590141

Re: [PATCH] Completed TODO: svn_stream_copy3()

Posted by Edmund Wong <ed...@kdtc.net>.
This is a bogus patch.  Please ignore.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1590334