You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "SchopenhauerZhang (via GitHub)" <gi...@apache.org> on 2023/03/22 07:49:08 UTC
[GitHub] [rocketmq] SchopenhauerZhang opened a new pull request, #6437: bugfix broker boot succes but get fail ip addr
SchopenhauerZhang opened a new pull request, #6437:
URL: https://github.com/apache/rocketmq/pull/6437
bug:
broker ip addr(IPV4) get fail after broker start up; fix:
add compare ,continue when ip is start with '0.' ; like :
The broker[broker-a, 0.0.1.1:10911] boot success. serializeType=JSON and name server is 127.0.0.1:9876;
fix:
issue [6436](https://github.com/apache/rocketmq/issues/6436)
**Make sure set the target branch to `develop`**
## What is the purpose of the change
<!--
If this PR fixes a GitHub issue, please add `fixes #<XXX>` or `closes #<XXX>`. Please refer to the documentation for more information:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
fix #<xxx> <!-- <xxx> replace with issue id -->
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhimins merged pull request #6437: [ISSUE #6436] Fix broker boot succes but get wrong ip address
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #6437:
URL: https://github.com/apache/rocketmq/pull/6437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] SchopenhauerZhang closed pull request #6437: bugfix broker boot succes but get fail ip addr
Posted by "SchopenhauerZhang (via GitHub)" <gi...@apache.org>.
SchopenhauerZhang closed pull request #6437: bugfix broker boot succes but get fail ip addr
URL: https://github.com/apache/rocketmq/pull/6437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-code-scanning[bot] commented on pull request #6437: [ISSUE #6436] bugfix broker boot succes but get fail ip addr
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #6437:
URL: https://github.com/apache/rocketmq/pull/6437#issuecomment-1489596461
You have successfully added a new CodeQL configuration `.github/workflows/codeql_analysis.yml:CodeQL-Build`. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository [Security tab](/apache/rocketmq/security/code-scanning?query=pr%3A6437+tool%3ACodeQL+is%3Aopen) to see all alerts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6437: [ISSUE #6436] bugfix broker boot succes but get fail ip addr
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6437:
URL: https://github.com/apache/rocketmq/pull/6437#issuecomment-1480445979
## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6437?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6437](https://codecov.io/gh/apache/rocketmq/pull/6437?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1acb594) into [develop](https://codecov.io/gh/apache/rocketmq/commit/c17baf1e33259db450617f59f2f2b0bc01505e87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c17baf1) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #6437 +/- ##
=============================================
- Coverage 43.13% 43.12% -0.01%
+ Complexity 8944 8937 -7
=============================================
Files 1105 1105
Lines 78057 78057
Branches 10160 10160
=============================================
- Hits 33666 33660 -6
- Misses 40176 40179 +3
- Partials 4215 4218 +3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/rocketmq/common/utils/NetworkUtil.java](https://codecov.io/gh/apache/rocketmq/pull/6437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvTmV0d29ya1V0aWwuamF2YQ==) | `50.00% <0.00%> (ø)` | |
... and [16 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6437/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org