You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/31 00:32:13 UTC
Review Request 62005: Used 'undiscardable' to protect a future in
MesosContainerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62005/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Gilbert Song.
Bugs: MESOS-7926
https://issues.apache.org/jira/browse/MESOS-7926
Repository: mesos
Description
-------
This patch addressed MESOS-7926 by protecting 'termination.future()'
with 'undiscardable'. This prevented the upstream discard event from
being propagated into 'termination.future()' which gets reused for
other calls.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918
Diff: https://reviews.apache.org/r/62005/diff/1/
Testing
-------
sudo make check
Ran the test in https://reviews.apache.org/r/61981 which previously fails. With this patch, the test passes.
Thanks,
Jie Yu
Re: Review Request 62005: Used 'undiscardable' to protect a future in
MesosContainerizer.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62005/#review184326
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2017, 4:27 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62005/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Gilbert Song.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch addressed MESOS-7926 by protecting 'termination.future()'
> with 'undiscardable'. This prevented the upstream discard event from
> being propagated into 'termination.future()' which gets reused for
> other calls.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918
>
>
> Diff: https://reviews.apache.org/r/62005/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
> Ran the test in https://reviews.apache.org/r/61981 which previously fails. With this patch, the test passes.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62005: Used 'undiscardable' to protect a future in
MesosContainerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62005/
-----------------------------------------------------------
(Updated Aug. 31, 2017, 11:27 p.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Gilbert Song.
Changes
-------
Adjusted the comments based on some feedback.
Bugs: MESOS-7926
https://issues.apache.org/jira/browse/MESOS-7926
Repository: mesos
Description
-------
This patch addressed MESOS-7926 by protecting 'termination.future()'
with 'undiscardable'. This prevented the upstream discard event from
being propagated into 'termination.future()' which gets reused for
other calls.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918
Diff: https://reviews.apache.org/r/62005/diff/3/
Changes: https://reviews.apache.org/r/62005/diff/2-3/
Testing
-------
sudo make check
Ran the test in https://reviews.apache.org/r/61981 which previously fails. With this patch, the test passes.
Thanks,
Jie Yu
Re: Review Request 62005: Used 'undiscardable' to protect a future in
MesosContainerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62005/#review184229
-----------------------------------------------------------
Bad patch!
Reviews applied: [61987, 62005]
Logs available here: http://104.210.40.105/logs/master/62005
- Mesos Reviewbot Windows
On Aug. 31, 2017, 12:33 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62005/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 12:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Gilbert Song.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch addressed MESOS-7926 by protecting 'termination.future()'
> with 'undiscardable'. This prevented the upstream discard event from
> being propagated into 'termination.future()' which gets reused for
> other calls.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918
>
>
> Diff: https://reviews.apache.org/r/62005/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
> Ran the test in https://reviews.apache.org/r/61981 which previously fails. With this patch, the test passes.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62005: Used 'undiscardable' to protect a future in
MesosContainerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62005/
-----------------------------------------------------------
(Updated Aug. 31, 2017, 12:33 a.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Gilbert Song.
Changes
-------
Slightly adjusted some comments.
Bugs: MESOS-7926
https://issues.apache.org/jira/browse/MESOS-7926
Repository: mesos
Description
-------
This patch addressed MESOS-7926 by protecting 'termination.future()'
with 'undiscardable'. This prevented the upstream discard event from
being propagated into 'termination.future()' which gets reused for
other calls.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918
Diff: https://reviews.apache.org/r/62005/diff/2/
Changes: https://reviews.apache.org/r/62005/diff/1-2/
Testing
-------
sudo make check
Ran the test in https://reviews.apache.org/r/61981 which previously fails. With this patch, the test passes.
Thanks,
Jie Yu