[GitHub] [maven-resolver] michael-o commented on a diff in pull request #220: [MRESOLVER-293] Update dependencies

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #220:
URL: https://github.com/apache/maven-resolver/pull/220#discussion_r1020777106


##########
maven-resolver-demos/maven-resolver-demo-snippets/pom.xml:
##########
@@ -127,7 +111,7 @@
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>
-      <scope>compile</scope>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>junit</groupId>

Review Comment:
   Are you certain about provided to runtime?



##########
maven-resolver-named-locks-redisson/pom.xml:
##########
@@ -39,7 +39,7 @@
     <Automatic-Module-Name>org.apache.maven.resolver.named.redisson</Automatic-Module-Name>
     <Bundle-SymbolicName>${Automatic-Module-Name}</Bundle-SymbolicName>
     <!-- Used in site also -->
-    <redissonVersion>3.17.5</redissonVersion>
+    <redissonVersion>3.17.7</redissonVersion>

Review Comment:
   Requires an update to the Markdown page.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org