[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5414: [Vmware] Use host FQDN if host IP is not found on VNC command

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5414:
URL: https://github.com/apache/cloudstack/pull/5414#discussion_r704062615



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -1177,14 +1178,23 @@ public boolean configureVm(Ternary<VirtualDevice, VirtualDeviceConfigSpecOperati
         return false;
     }
 
+    private String getHostFqdn(HostMO hostMO, String hostName) {

Review comment:
       @nvazquez I think, it is better to keep this method in HostMO.
   
   ```
   public String getHostFqdn() {
           try {
                HostDnsConfig hostDnsConfig = getHostNetworkInfo().getDnsConfig();
                return String.format("%s.%s", hostDnsConfig.getHostName(), hostDnsConfig.getDomainName());
            } catch (Exception e) {
                s_logger.error("Could not get host FQDN for host: " + getHostName());
            }
            return null;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org