You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ted Yu <yu...@gmail.com> on 2017/12/15 19:56:13 UTC
[VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Hi,
Here is the discussion thread:
http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
Please vote on this KIP.
Thanks
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Richard Yu <yo...@gmail.com>.
There are 3 binding votes and 2 nonbinding votes in favor of KIP-239.
Binding:
Guozhang Wang
Damian Guy
Ewen Cheslack-Postava
Nonbinding:
Matthias J. Sax
Bill Bejeck
This would close this voting thread.
On Tue, Jan 2, 2018 at 10:24 PM, Matthias J. Sax <ma...@confluent.io>
wrote:
> @Richard: you can close this vote thread with a summary as usual and
> update the KIP wiki page accordingly.
>
>
> -Matthias
>
> On 1/2/18 9:57 PM, Richard Yu wrote:
> > A subsequent PR has already been created:
> > https://github.com/apache/kafka/pull/4340/
> > It should be seen on the JIRA.
> >
> >
> >
> > On Tue, Jan 2, 2018 at 9:51 PM, Ewen Cheslack-Postava <ewen@confluent.io
> >
> > wrote:
> >
> >> Oh, the KIP passes w/ the required votes. My comment was just on
> >> implementation details. I will leave comments about that up to the
> >> subsequent PR and to the Kafka Streams folks that are much better suited
> >> than me to comment on them :)
> >>
> >> -Ewen
> >>
> >> On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yo...@gmail.com>
> >> wrote:
> >>
> >>> After investigation, I have found that the
> >>> InternalStreamsBuilder#globalTable method is the only instance where
> the
> >>> constructor for GlobalKTableImpl is called.
> >>> The KTableValueGetterSupplier parameter used in this particular
> >> constructor
> >>> is an instance of KTableSourceValueGetterSupplier. Hence, your
> >> requirement
> >>> is satisfied.
> >>>
> >>> Since this is the vote thread, if you have further comments, please
> >> comment
> >>> on the pull request.
> >>>
> >>> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <
> ewen@confluent.io
> >>>
> >>> wrote:
> >>>
> >>>> +1 binding
> >>>>
> >>>> The idea seems reasonable. Looking at it implementation-wise, seems
> >> there
> >>>> is a bit of awkwardness because GlobalKTableImpl uses a
> >>>> KTableValueGetterSupplier which seems to possibly have multiple
> stores,
> >>> but
> >>>> maybe using the more specific KTableSourceValueGetterSupplier
> >>>> implementation instead can resolve that.
> >>>>
> >>>> -Ewen
> >>>>
> >>>> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yu...@gmail.com> wrote:
> >>>>
> >>>>> Gentle reminder: one more binding vote is needed for the KIP to pass.
> >>>>>
> >>>>> Cheers
> >>>>>
> >>>>> On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com>
> >>>> wrote:
> >>>>>
> >>>>>> +1
> >>>>>>
> >>>>>> On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
> >>>>>>
> >>>>>>> Ping for more (binding) votes.
> >>>>>>>
> >>>>>>> The pull request is ready.
> >>>>>>>
> >>>>>>> On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <
> >>> wangguoz@gmail.com>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> +1 (binding), thanks!
> >>>>>>>>
> >>>>>>>> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com>
> >>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Hi,
> >>>>>>>>> Here is the discussion thread:
> >>>>>>>>>
> >>>>>>>>> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> >>>>>>>>> Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> >>>>>>>>>
> >>>>>>>>> Please vote on this KIP.
> >>>>>>>>>
> >>>>>>>>> Thanks
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> -- Guozhang
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >
>
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by "Matthias J. Sax" <ma...@confluent.io>.
@Richard: you can close this vote thread with a summary as usual and
update the KIP wiki page accordingly.
-Matthias
On 1/2/18 9:57 PM, Richard Yu wrote:
> A subsequent PR has already been created:
> https://github.com/apache/kafka/pull/4340/
> It should be seen on the JIRA.
>
>
>
> On Tue, Jan 2, 2018 at 9:51 PM, Ewen Cheslack-Postava <ew...@confluent.io>
> wrote:
>
>> Oh, the KIP passes w/ the required votes. My comment was just on
>> implementation details. I will leave comments about that up to the
>> subsequent PR and to the Kafka Streams folks that are much better suited
>> than me to comment on them :)
>>
>> -Ewen
>>
>> On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yo...@gmail.com>
>> wrote:
>>
>>> After investigation, I have found that the
>>> InternalStreamsBuilder#globalTable method is the only instance where the
>>> constructor for GlobalKTableImpl is called.
>>> The KTableValueGetterSupplier parameter used in this particular
>> constructor
>>> is an instance of KTableSourceValueGetterSupplier. Hence, your
>> requirement
>>> is satisfied.
>>>
>>> Since this is the vote thread, if you have further comments, please
>> comment
>>> on the pull request.
>>>
>>> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ewen@confluent.io
>>>
>>> wrote:
>>>
>>>> +1 binding
>>>>
>>>> The idea seems reasonable. Looking at it implementation-wise, seems
>> there
>>>> is a bit of awkwardness because GlobalKTableImpl uses a
>>>> KTableValueGetterSupplier which seems to possibly have multiple stores,
>>> but
>>>> maybe using the more specific KTableSourceValueGetterSupplier
>>>> implementation instead can resolve that.
>>>>
>>>> -Ewen
>>>>
>>>> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yu...@gmail.com> wrote:
>>>>
>>>>> Gentle reminder: one more binding vote is needed for the KIP to pass.
>>>>>
>>>>> Cheers
>>>>>
>>>>> On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com>
>>>> wrote:
>>>>>
>>>>>> +1
>>>>>>
>>>>>> On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
>>>>>>
>>>>>>> Ping for more (binding) votes.
>>>>>>>
>>>>>>> The pull request is ready.
>>>>>>>
>>>>>>> On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <
>>> wangguoz@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1 (binding), thanks!
>>>>>>>>
>>>>>>>> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com>
>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>> Here is the discussion thread:
>>>>>>>>>
>>>>>>>>> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
>>>>>>>>> Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
>>>>>>>>>
>>>>>>>>> Please vote on this KIP.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> -- Guozhang
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Richard Yu <yo...@gmail.com>.
A subsequent PR has already been created:
https://github.com/apache/kafka/pull/4340/
It should be seen on the JIRA.
On Tue, Jan 2, 2018 at 9:51 PM, Ewen Cheslack-Postava <ew...@confluent.io>
wrote:
> Oh, the KIP passes w/ the required votes. My comment was just on
> implementation details. I will leave comments about that up to the
> subsequent PR and to the Kafka Streams folks that are much better suited
> than me to comment on them :)
>
> -Ewen
>
> On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yo...@gmail.com>
> wrote:
>
> > After investigation, I have found that the
> > InternalStreamsBuilder#globalTable method is the only instance where the
> > constructor for GlobalKTableImpl is called.
> > The KTableValueGetterSupplier parameter used in this particular
> constructor
> > is an instance of KTableSourceValueGetterSupplier. Hence, your
> requirement
> > is satisfied.
> >
> > Since this is the vote thread, if you have further comments, please
> comment
> > on the pull request.
> >
> > On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ewen@confluent.io
> >
> > wrote:
> >
> > > +1 binding
> > >
> > > The idea seems reasonable. Looking at it implementation-wise, seems
> there
> > > is a bit of awkwardness because GlobalKTableImpl uses a
> > > KTableValueGetterSupplier which seems to possibly have multiple stores,
> > but
> > > maybe using the more specific KTableSourceValueGetterSupplier
> > > implementation instead can resolve that.
> > >
> > > -Ewen
> > >
> > > On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yu...@gmail.com> wrote:
> > >
> > > > Gentle reminder: one more binding vote is needed for the KIP to pass.
> > > >
> > > > Cheers
> > > >
> > > > On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com>
> > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
> > > > >
> > > > > > Ping for more (binding) votes.
> > > > > >
> > > > > > The pull request is ready.
> > > > > >
> > > > > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <
> > wangguoz@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > +1 (binding), thanks!
> > > > > > >
> > > > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com>
> > > > wrote:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > > Here is the discussion thread:
> > > > > > > >
> > > > > > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > > > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > > > > > >
> > > > > > > > Please vote on this KIP.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > -- Guozhang
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Ewen Cheslack-Postava <ew...@confluent.io>.
Oh, the KIP passes w/ the required votes. My comment was just on
implementation details. I will leave comments about that up to the
subsequent PR and to the Kafka Streams folks that are much better suited
than me to comment on them :)
-Ewen
On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yo...@gmail.com>
wrote:
> After investigation, I have found that the
> InternalStreamsBuilder#globalTable method is the only instance where the
> constructor for GlobalKTableImpl is called.
> The KTableValueGetterSupplier parameter used in this particular constructor
> is an instance of KTableSourceValueGetterSupplier. Hence, your requirement
> is satisfied.
>
> Since this is the vote thread, if you have further comments, please comment
> on the pull request.
>
> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ew...@confluent.io>
> wrote:
>
> > +1 binding
> >
> > The idea seems reasonable. Looking at it implementation-wise, seems there
> > is a bit of awkwardness because GlobalKTableImpl uses a
> > KTableValueGetterSupplier which seems to possibly have multiple stores,
> but
> > maybe using the more specific KTableSourceValueGetterSupplier
> > implementation instead can resolve that.
> >
> > -Ewen
> >
> > On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > Gentle reminder: one more binding vote is needed for the KIP to pass.
> > >
> > > Cheers
> > >
> > > On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com>
> > wrote:
> > >
> > > > +1
> > > >
> > > > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
> > > >
> > > > > Ping for more (binding) votes.
> > > > >
> > > > > The pull request is ready.
> > > > >
> > > > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <
> wangguoz@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 (binding), thanks!
> > > > > >
> > > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > > Here is the discussion thread:
> > > > > > >
> > > > > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > > > > >
> > > > > > > Please vote on this KIP.
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > -- Guozhang
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Richard Yu <yo...@gmail.com>.
After investigation, I have found that the
InternalStreamsBuilder#globalTable method is the only instance where the
constructor for GlobalKTableImpl is called.
The KTableValueGetterSupplier parameter used in this particular constructor
is an instance of KTableSourceValueGetterSupplier. Hence, your requirement
is satisfied.
Since this is the vote thread, if you have further comments, please comment
on the pull request.
On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava <ew...@confluent.io>
wrote:
> +1 binding
>
> The idea seems reasonable. Looking at it implementation-wise, seems there
> is a bit of awkwardness because GlobalKTableImpl uses a
> KTableValueGetterSupplier which seems to possibly have multiple stores, but
> maybe using the more specific KTableSourceValueGetterSupplier
> implementation instead can resolve that.
>
> -Ewen
>
> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > Gentle reminder: one more binding vote is needed for the KIP to pass.
> >
> > Cheers
> >
> > On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com>
> wrote:
> >
> > > +1
> > >
> > > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
> > >
> > > > Ping for more (binding) votes.
> > > >
> > > > The pull request is ready.
> > > >
> > > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wa...@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (binding), thanks!
> > > > >
> > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com>
> > wrote:
> > > > >
> > > > > > Hi,
> > > > > > Here is the discussion thread:
> > > > > >
> > > > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > > > >
> > > > > > Please vote on this KIP.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > -- Guozhang
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Ewen Cheslack-Postava <ew...@confluent.io>.
+1 binding
The idea seems reasonable. Looking at it implementation-wise, seems there
is a bit of awkwardness because GlobalKTableImpl uses a
KTableValueGetterSupplier which seems to possibly have multiple stores, but
maybe using the more specific KTableSourceValueGetterSupplier
implementation instead can resolve that.
-Ewen
On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yu...@gmail.com> wrote:
> Gentle reminder: one more binding vote is needed for the KIP to pass.
>
> Cheers
>
> On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com> wrote:
>
> > +1
> >
> > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
> >
> > > Ping for more (binding) votes.
> > >
> > > The pull request is ready.
> > >
> > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wa...@gmail.com>
> > > wrote:
> > >
> > > > +1 (binding), thanks!
> > > >
> > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com>
> wrote:
> > > >
> > > > > Hi,
> > > > > Here is the discussion thread:
> > > > >
> > > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > > >
> > > > > Please vote on this KIP.
> > > > >
> > > > > Thanks
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > -- Guozhang
> > > >
> > >
> >
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Ted Yu <yu...@gmail.com>.
Gentle reminder: one more binding vote is needed for the KIP to pass.
Cheers
On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <da...@gmail.com> wrote:
> +1
>
> On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
>
> > Ping for more (binding) votes.
> >
> > The pull request is ready.
> >
> > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wa...@gmail.com>
> > wrote:
> >
> > > +1 (binding), thanks!
> > >
> > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com> wrote:
> > >
> > > > Hi,
> > > > Here is the discussion thread:
> > > >
> > > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > > >
> > > > Please vote on this KIP.
> > > >
> > > > Thanks
> > > >
> > >
> > >
> > >
> > > --
> > > -- Guozhang
> > >
> >
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Damian Guy <da...@gmail.com>.
+1
On Wed, 20 Dec 2017 at 21:09 Ted Yu <yu...@gmail.com> wrote:
> Ping for more (binding) votes.
>
> The pull request is ready.
>
> On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wa...@gmail.com>
> wrote:
>
> > +1 (binding), thanks!
> >
> > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > Hi,
> > > Here is the discussion thread:
> > >
> > > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> > >
> > > Please vote on this KIP.
> > >
> > > Thanks
> > >
> >
> >
> >
> > --
> > -- Guozhang
> >
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Ted Yu <yu...@gmail.com>.
Ping for more (binding) votes.
The pull request is ready.
On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wa...@gmail.com> wrote:
> +1 (binding), thanks!
>
> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > Hi,
> > Here is the discussion thread:
> >
> > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> >
> > Please vote on this KIP.
> >
> > Thanks
> >
>
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Bill Bejeck <bb...@gmail.com>.
+1
On Fri, Dec 15, 2017 at 3:57 PM, Guozhang Wang <wa...@gmail.com> wrote:
> +1 (binding), thanks!
>
> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > Hi,
> > Here is the discussion thread:
> >
> > http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> > Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
> >
> > Please vote on this KIP.
> >
> > Thanks
> >
>
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by Guozhang Wang <wa...@gmail.com>.
+1 (binding), thanks!
On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yu...@gmail.com> wrote:
> Hi,
> Here is the discussion thread:
>
> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=
> Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
>
> Please vote on this KIP.
>
> Thanks
>
--
-- Guozhang
Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1
On 12/15/17 11:56 AM, Ted Yu wrote:
> Hi,
> Here is the discussion thread:
>
> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable
>
> Please vote on this KIP.
>
> Thanks
>