You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 17:26:59 UTC

[jira] [Created] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover

after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
----------------------------------------------------------------------------------------------

                 Key: SOLR-3112
                 URL: https://issues.apache.org/jira/browse/SOLR-3112
             Project: Solr
          Issue Type: Bug
            Reporter: Robert Muir
             Fix For: 3.6, 4.0


This is especially confusing, as then it looks like you dont have a clean checkout.

For now it should be under svn:ignore, but ultimately we really should not be creating files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover

Posted by "Luca Cavanna (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luca Cavanna updated SOLR-3112:
-------------------------------

    Attachment: SOLR-3112.patch

I noticed that TestSolrProperties and TestEmbeddedSolrServer were really similar. They both worked on the test-files folder, but the last one cleaned everything at the end, while the second one not.
I created a base class to avoid copy pasting the same code, then I changed both to work on a temp directory, without modifying anything on the test-files folder.

Regarding the other elevate-data-distrib.xml problem mentioned in the SOLR-3268, I had a look at it. It seems to copy the core/src/test-files/solr/conf/elevate.xml to same path but different filename (elevate-data-distrib.xml) right before testing. Then the test uses the new file and doesn't clean it at the end. Well, I wonder why the test makes that copy. Maybe I didn't get something, but rather than cleaning at the end, my patch removes that copy and the test seems to work anyway. Let me know if there's a better fix for this!
                
> after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3112
>                 URL: https://issues.apache.org/jira/browse/SOLR-3112
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3112.patch
>
>
> This is especially confusing, as then it looks like you dont have a clean checkout.
> For now it should be under svn:ignore, but ultimately we really should not be creating files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover

Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved SOLR-3112.
-------------------------------

    Resolution: Fixed

Wow, thanks Luca for fixing these test issues! I just committed this.
                
> after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3112
>                 URL: https://issues.apache.org/jira/browse/SOLR-3112
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3112.patch
>
>
> This is especially confusing, as then it looks like you dont have a clean checkout.
> For now it should be under svn:ignore, but ultimately we really should not be creating files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover

Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236746#comment-13236746 ] 

Uwe Schindler commented on SOLR-3112:
-------------------------------------

Thanks!

One thing: we should now be able to remove the extra <delete/> and the extra comment on "ant clean" in solr's build.xml?
                
> after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3112
>                 URL: https://issues.apache.org/jira/browse/SOLR-3112
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3112.patch
>
>
> This is especially confusing, as then it looks like you dont have a clean checkout.
> For now it should be under svn:ignore, but ultimately we really should not be creating files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover

Posted by "Luca Cavanna (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236493#comment-13236493 ] 

Luca Cavanna commented on SOLR-3112:
------------------------------------

Looks like the test which leaves the test-solr.xml there is TestEmbeddedSolrServer. I'm working on fixing it.
                
> after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3112
>                 URL: https://issues.apache.org/jira/browse/SOLR-3112
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>
> This is especially confusing, as then it looks like you dont have a clean checkout.
> For now it should be under svn:ignore, but ultimately we really should not be creating files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3112) after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236508#comment-13236508 ] 

Robert Muir commented on SOLR-3112:
-----------------------------------

Thanks for taking a look Luca! 
I was unable to fix this with my first shot on SOLR-3268... I'm guessing really the test just needs to be fixed.
                
> after running 'ant test' solr/solrj/src/test-files/solrj/solr/shared/test-solr.xml is leftover
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3112
>                 URL: https://issues.apache.org/jira/browse/SOLR-3112
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>
> This is especially confusing, as then it looks like you dont have a clean checkout.
> For now it should be under svn:ignore, but ultimately we really should not be creating files under src/test-files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org