You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gary Helmling (JIRA)" <ji...@apache.org> on 2011/04/06 00:52:06 UTC
[jira] [Created] (HBASE-3739) HMaster.getProtocolVersion() ignores
HMasterRegionInterface.VERSION
HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
-------------------------------------------------------------------
Key: HBASE-3739
URL: https://issues.apache.org/jira/browse/HBASE-3739
Project: HBase
Issue Type: Bug
Components: ipc
Reporter: Gary Helmling
Priority: Minor
The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3739) HMaster.getProtocolVersion()
ignores HMasterRegionInterface.VERSION
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016219#comment-13016219 ]
stack commented on HBASE-3739:
------------------------------
+1 I ran into this issue over in hbase-1502 and did same fix there. Thanks Gary.
> HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
> -------------------------------------------------------------------
>
> Key: HBASE-3739
> URL: https://issues.apache.org/jira/browse/HBASE-3739
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-3739.patch
>
>
> The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3739) HMaster.getProtocolVersion() ignores
HMasterRegionInterface.VERSION
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling reassigned HBASE-3739:
------------------------------------
Assignee: Gary Helmling
> HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
> -------------------------------------------------------------------
>
> Key: HBASE-3739
> URL: https://issues.apache.org/jira/browse/HBASE-3739
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Attachments: HBASE-3739.patch
>
>
> The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3739) HMaster.getProtocolVersion() ignores
HMasterRegionInterface.VERSION
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling resolved HBASE-3739.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Committed to trunk.
> HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
> -------------------------------------------------------------------
>
> Key: HBASE-3739
> URL: https://issues.apache.org/jira/browse/HBASE-3739
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-3739.patch
>
>
> The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3739) HMaster.getProtocolVersion()
ignores HMasterRegionInterface.VERSION
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016239#comment-13016239 ]
Hudson commented on HBASE-3739:
-------------------------------
Integrated in HBase-TRUNK #1831 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1831/])
HBASE-3739 HMaster.getProtocolVersion() should distinguish HMasterInterface and HMasterRegionInterface versions
> HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
> -------------------------------------------------------------------
>
> Key: HBASE-3739
> URL: https://issues.apache.org/jira/browse/HBASE-3739
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-3739.patch
>
>
> The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3739) HMaster.getProtocolVersion()
ignores HMasterRegionInterface.VERSION
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016185#comment-13016185 ]
Andrew Purtell commented on HBASE-3739:
---------------------------------------
+1
> HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
> -------------------------------------------------------------------
>
> Key: HBASE-3739
> URL: https://issues.apache.org/jira/browse/HBASE-3739
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Priority: Minor
> Attachments: HBASE-3739.patch
>
>
> The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3739) HMaster.getProtocolVersion() ignores
HMasterRegionInterface.VERSION
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-3739:
---------------------------------
Attachment: HBASE-3739.patch
Simple patch to return appropriate version depending on requested protocol.
> HMaster.getProtocolVersion() ignores HMasterRegionInterface.VERSION
> -------------------------------------------------------------------
>
> Key: HBASE-3739
> URL: https://issues.apache.org/jira/browse/HBASE-3739
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Priority: Minor
> Attachments: HBASE-3739.patch
>
>
> The recent split of RPC protocol version numbers doesn't work quite as expected with HMasterRegionInterface. Since HMaster implements both HMasterInterface and HMasterRegionInterface, its getProtocolVersion() implementation needs to check the requested protocol name and return either the HMasterInterface.VERSION value or HMasterRegionInterface.VERSION value as appropriate.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira