[GitHub] [inlong] woofyzhao commented on a diff in pull request #6046: [INLONG-6044][Manager] Distinguish between group and stream configuration processes

[GitBox <gi...@apache.org>]

woofyzhao commented on code in PR #6046:
URL: https://github.com/apache/inlong/pull/6046#discussion_r996413174


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/group/UpdateGroupCompleteListener.java:
##########
@@ -75,7 +84,14 @@ public ListenerResult listen(WorkflowContext context) {
         }
         InlongGroupInfo groupInfo = form.getGroupInfo();
         groupService.update(groupInfo.genRequest(), operator);
-
+        if (Objects.equals(operateType, GroupOperateType.DELETE)) {

Review Comment:
   should we allow deleting a group directly while there are streams under it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org