[GitHub] [shardingsphere] sandynz opened a new issue, #22445: Ignore license header for ShardingSphereDriverURL.toConfigurationBytes()

[GitBox <gi...@apache.org>]

sandynz opened a new issue, #22445:
URL: https://github.com/apache/shardingsphere/issues/22445

   Currently, ShardingSphereDriverURL.toConfigurationBytes() will from driver yaml and convert content to byte array which include license header. And ShardingSphereDriverURLTest will assert byte array length, e.g.
   ```
       @Test
       public void assertToClasspathConfigurationFile() {
           ShardingSphereDriverURL actual = new ShardingSphereDriverURL("jdbc:shardingsphere:classpath:config/driver/foo-driver-fixture.yaml");
           assertThat(actual.toConfigurationBytes().length, is(822));
       }
   ```
   
   It's better to ignore license header, so when license header is changed, it won't affect unit test.
   
   Possible changes:
   - ShardingSphereDriverURL.toConfigurationBytes() ignore license header
   - Update ShardingSphereDriverURLTest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz closed issue #22445: Ignore license header for ShardingSphereDriverURL.toConfigurationBytes()

[GitBox <gi...@apache.org>]

sandynz closed issue #22445: Ignore license header for ShardingSphereDriverURL.toConfigurationBytes()
URL: https://github.com/apache/shardingsphere/issues/22445


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org