You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/03/23 14:57:28 UTC
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/518
[FLINK-1650] Configure Netty (akka) to use Slf4j.
It seems that Netty 3.8.0 used by Akka was using `java.util.logging` for its internal logging, that's why this entry was without effect: https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/conf/log4j.properties#L29.
The change sets the Netty logging factory to Slf4j. This means that Netty is now using Sfl4j. It'll also respect our logging settings (`org.jboss.netty.channel.DefaultChannelPipeline` to lvl ERROR).
Lets see if the exception now disappears.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink1650
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #518
----
commit d4778d4d51cd20db2861b3632e64aeac1f5f6f7a
Author: Robert Metzger <rm...@apache.org>
Date: 2015-03-23T10:42:21Z
[FLINK-1650] Set akka version to 2.3.9
commit 69b6a9b497955544e0e5c8707293c580e1ba3d5e
Author: Robert Metzger <rm...@apache.org>
Date: 2015-03-23T13:44:19Z
[FLINK-1650] Let Netty(Akka) use Slf4j
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-86050697
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-85678768
I moved the call to the Akka utils.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-85160071
The build passed in my travis: https://travis-ci.org/rmetzger/flink/builds/55487319
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-85426018
Good find, but just calling it in the beginning of every main() method seems hacky.
I think the code should go to the AkkaUtils.createActorSystem() method. Then we also need it only once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-86944772
I'll merge the change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-85239319
Great to hear that you figured out why we could not suppress this error :-)
On Mon, Mar 23, 2015 at 8:33 PM, Robert Metzger <no...@github.com>
wrote:
> The build passed in my travis:
> https://travis-ci.org/rmetzger/flink/builds/55487319
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/518#issuecomment-85160071>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1650] Configure Netty (akka) to use Slf...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/518#issuecomment-85244078
+1 nice find
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---