You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2023/10/04 09:07:38 UTC
[PR] Added Missing license headers and license headers to generation of tr… [camel-k]
oscerd opened a new pull request, #4790:
URL: https://github.com/apache/camel-k/pull/4790
…aits.yaml
**Release Note**
```release-note
Added license headers
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Missing license headers and license headers to generation of tr… [camel-k]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #4790:
URL: https://github.com/apache/camel-k/pull/4790#discussion_r1345487084
##########
cmd/util/doc-gen/generators/traitmetadatagen.go:
##########
@@ -113,6 +130,7 @@ func (g *traitMetaDataGen) Finalize(c *generator.Context, w io.Writer) error {
return err
}
+ fmt.Fprintf(file, "%s", string(licenseHeader))
Review Comment:
If you run the make check-licenses the pkg/resources/traits.yaml is listed as missing license. So this is just for him. For the doc we should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Missing license headers and license headers to generation of tr… [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4790:
URL: https://github.com/apache/camel-k/pull/4790#discussion_r1345484232
##########
cmd/util/doc-gen/generators/traitmetadatagen.go:
##########
@@ -113,6 +130,7 @@ func (g *traitMetaDataGen) Finalize(c *generator.Context, w io.Writer) error {
return err
}
+ fmt.Fprintf(file, "%s", string(licenseHeader))
Review Comment:
Is it this required? I mean, in the doc we are not adding licenses in general, so, if we're doing here we may need to add to the rest of the doc as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Missing license headers and license headers to generation of tr… [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4790:
URL: https://github.com/apache/camel-k/pull/4790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org