You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2024/03/11 08:53:55 UTC
[I] Events not generating for BaseCmd classes [cloudstack]
vishesh92 opened a new issue, #8771:
URL: https://github.com/apache/cloudstack/issues/8771
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Improvement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
all
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
Events are not being generated for commands which extend BaseCmd. This results in missing events for some commands.
Ref.: https://github.com/apache/cloudstack/pull/8630#pullrequestreview-1914158484
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events not generating for BaseCmd classes [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on issue #8771:
URL: https://github.com/apache/cloudstack/issues/8771#issuecomment-2158132474
In my understanding, action events in ACS are created mainly by the `@ActionEvent` annotation. For `BaseAsyncCmd` we do publish events with `Scheduled` state but that is just it. Trying to publish events for `BaseCmd` may require a lot of changes and refactoring. Would it be better to fix the specific cases where events are not generated highlighted in https://github.com/apache/cloudstack/pull/8630#pullrequestreview-1914158484?
@vishesh92 @rohityadavcloud @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events not generating for BaseCmd classes [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #8771:
URL: https://github.com/apache/cloudstack/issues/8771#issuecomment-2701493377
I'm not sure how complicated this will be but it seems mostly search work per event, so @vishesh92 let's make seperate child issues for
- hosts
- projects
- internal lb
- ssh key pairs
- affinity groups
- vm snapshots
- firewall
- static nat
as per @kiranchavala 's report in https://github.com/apache/cloudstack/pull/8630#pullrequestreview-1914158484
makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events not generating for BaseCmd classes [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #8771:
URL: https://github.com/apache/cloudstack/issues/8771#issuecomment-3245133458
fixed few cases mentioned in the comments by the PR https://github.com/apache/cloudstack/pull/11230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events not generating for BaseCmd classes [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala closed issue #8771: Events not generating for BaseCmd classes
URL: https://github.com/apache/cloudstack/issues/8771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events not generating for BaseCmd classes [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on issue #8771:
URL: https://github.com/apache/cloudstack/issues/8771#issuecomment-2609040132
> Agreed with [@shwstppr](https://github.com/shwstppr) comment, it is mainly addressed by ActionEvent annotation. I prefer to fix the specific cases. [@vishesh92](https://github.com/vishesh92) are you fine with this ?
I was thinking of a standard way in order to ensure we don't miss it for new commands added in the future. If the effort seems a lot, I am okay with specific cases as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events not generating for BaseCmd classes [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #8771:
URL: https://github.com/apache/cloudstack/issues/8771#issuecomment-2603678049
> In my understanding, action events in ACS are created mainly by the `@ActionEvent` annotation. For `BaseAsyncCmd` we do publish events with `Scheduled` state but that is just it. Trying to publish events for `BaseCmd` may require a lot of changes and refactoring. Would it be better to fix the specific cases where events are not generated highlighted in [#8630 (review)](https://github.com/apache/cloudstack/pull/8630#pullrequestreview-1914158484)? [@vishesh92](https://github.com/vishesh92) [@rohityadavcloud](https://github.com/rohityadavcloud) [@sureshanaparti](https://github.com/sureshanaparti)
Agreed with @shwstppr comment, it is mainly addressed by ActionEvent annotation. I prefer to fix the specific cases. @vishesh92 are you fine with this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org