You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2016/03/17 06:49:04 UTC
spark git commit: [MINOR][SQL][BUILD] Remove duplicated lines
Repository: spark
Updated Branches:
refs/heads/master 7eef2463a -> c890c359b
[MINOR][SQL][BUILD] Remove duplicated lines
## What changes were proposed in this pull request?
This PR removes three minor duplicated lines. First one is making the following unreachable code warning.
```
JoinSuite.scala:52: unreachable code
[warn] case j: BroadcastHashJoin => j
```
The other two are just consecutive repetitions in `Seq` of MiMa filters.
## How was this patch tested?
Pass the existing Jenkins test.
Author: Dongjoon Hyun <do...@apache.org>
Closes #11773 from dongjoon-hyun/remove_duplicated_line.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/c890c359
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/c890c359
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/c890c359
Branch: refs/heads/master
Commit: c890c359b1dfb64274d1d0067b1e16d834035f11
Parents: 7eef246
Author: Dongjoon Hyun <do...@apache.org>
Authored: Wed Mar 16 22:48:58 2016 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Wed Mar 16 22:48:58 2016 -0700
----------------------------------------------------------------------
project/MimaExcludes.scala | 2 --
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala | 1 -
2 files changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/c890c359/project/MimaExcludes.scala
----------------------------------------------------------------------
diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala
index ffc6fa0..6d39282 100644
--- a/project/MimaExcludes.scala
+++ b/project/MimaExcludes.scala
@@ -301,13 +301,11 @@ object MimaExcludes {
// [SPARK-13244][SQL] Migrates DataFrame to Dataset
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.sql.DataFrameHolder.apply"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.DataFrameHolder.toDF"),
- ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.DataFrameHolder.toDF"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.sql.DataFrameHolder.copy"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.DataFrameHolder.copy$default$1"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.DataFrameHolder.df$1"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.sql.DataFrameHolder.this"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.SQLContext.tables"),
- ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.SQLContext.tables"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.SQLContext.sql"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.SQLContext.baseRelationToDataFrame"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.SQLContext.table"),
http://git-wip-us.apache.org/repos/asf/spark/blob/c890c359/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
index 4191991..03d6df8 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
@@ -49,7 +49,6 @@ class JoinSuite extends QueryTest with SharedSQLContext {
case j: BroadcastHashJoin => j
case j: CartesianProduct => j
case j: BroadcastNestedLoopJoin => j
- case j: BroadcastHashJoin => j
case j: SortMergeJoin => j
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org