You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/01/04 00:32:34 UTC
Re: Review Request: Added string replace utility to stout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8043/
-----------------------------------------------------------
(Updated Jan. 3, 2013, 11:32 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's comments and rebased off trunk
Description
-------
Needed this while I was doing the refactor for properly cleaning up slave work directories during tests.
Diffs (updated)
-----
src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666
src/tests/utils.cpp 3e01dc98f56f35141c793fc52fc7ea19f2e22135
third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd
Diff: https://reviews.apache.org/r/8043/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Added string replace utility to stout
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8043/#review16877
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 21, 2013, 7:43 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8043/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 7:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Needed this while I was doing the refactor for properly cleaning up slave work directories during tests.
>
>
> Diffs
> -----
>
> src/tests/stout_tests.cpp 6d01330f7009ec94b3b11c89c562eceed4515a3e
> src/tests/utils.cpp 3e01dc98f56f35141c793fc52fc7ea19f2e22135
> third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd
>
> Diff: https://reviews.apache.org/r/8043/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added string replace utility to stout
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8043/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 7:43 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
BenH's comments and rebased off trunk.
Description
-------
Needed this while I was doing the refactor for properly cleaning up slave work directories during tests.
Diffs (updated)
-----
src/tests/stout_tests.cpp 6d01330f7009ec94b3b11c89c562eceed4515a3e
src/tests/utils.cpp 3e01dc98f56f35141c793fc52fc7ea19f2e22135
third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd
Diff: https://reviews.apache.org/r/8043/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Added string replace utility to stout
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8043/#review16792
-----------------------------------------------------------
src/tests/utils.cpp
<https://reviews.apache.org/r/8043/#comment35676>
confirm if const char* is legal for referring to temps.
third_party/libprocess/include/stout/strings.hpp
<https://reviews.apache.org/r/8043/#comment35674>
s/from/s/
s/find/from/
s/replace/to/
third_party/libprocess/include/stout/strings.hpp
<https://reviews.apache.org/r/8043/#comment35675>
s/pos/index/
- Vinod Kone
On Jan. 3, 2013, 11:32 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8043/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 11:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Needed this while I was doing the refactor for properly cleaning up slave work directories during tests.
>
>
> Diffs
> -----
>
> src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666
> src/tests/utils.cpp 3e01dc98f56f35141c793fc52fc7ea19f2e22135
> third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd
>
> Diff: https://reviews.apache.org/r/8043/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>