You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/20 19:25:37 UTC
[GitHub] [openwhisk] dgrove-oss opened a new pull request #4802: kafka
server version currency
dgrove-oss opened a new pull request #4802: kafka server version currency
URL: https://github.com/apache/openwhisk/pull/4802
Major jump in kafka docker image tag from 0.11.0.1 to 2.12-2.3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4802: upgrade kafka
server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#issuecomment-582655023
Now works with both SSL and non-SSL configuration in both normal and HA modes. PR is ready for final review and merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4802: upgrade kafka
server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#issuecomment-581713776
Works now for default (non-SSL) configuration. Need to look at SSL config next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on a change in pull request #4802:
upgrade kafka server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#discussion_r376457755
##########
File path: tests/src/test/scala/services/KafkaConnectorTests.scala
##########
@@ -148,7 +148,7 @@ class KafkaConnectorTests
kafkaHosts.indices.foreach { i =>
val message = createMessage()
val kafkaHost = kafkaHosts(i).split(":")(0)
- val startLog = s", started"
+ val startLog = s"\\[KafkaServer id=$i\\] started"
Review comment:
reverted. need the `\[ `to avoid regex interpreting it as a character class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss merged pull request #4802: upgrade kafka
server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on a change in pull request #4802:
upgrade kafka server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#discussion_r375892302
##########
File path: tests/src/test/scala/services/KafkaConnectorTests.scala
##########
@@ -148,7 +148,7 @@ class KafkaConnectorTests
kafkaHosts.indices.foreach { i =>
val message = createMessage()
val kafkaHost = kafkaHosts(i).split(":")(0)
- val startLog = s", started"
+ val startLog = s"\\[KafkaServer id=$i\\] started"
Review comment:
made change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on a change in pull request #4802:
upgrade kafka server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#discussion_r376457755
##########
File path: tests/src/test/scala/services/KafkaConnectorTests.scala
##########
@@ -148,7 +148,7 @@ class KafkaConnectorTests
kafkaHosts.indices.foreach { i =>
val message = createMessage()
val kafkaHost = kafkaHosts(i).split(":")(0)
- val startLog = s", started"
+ val startLog = s"\\[KafkaServer id=$i\\] started"
Review comment:
reverted. need the \[ to avoid regex interpreting it as a character class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4802:
upgrade kafka server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#discussion_r375869151
##########
File path: tests/src/test/scala/services/KafkaConnectorTests.scala
##########
@@ -148,7 +148,7 @@ class KafkaConnectorTests
kafkaHosts.indices.foreach { i =>
val message = createMessage()
val kafkaHost = kafkaHosts(i).split(":")(0)
- val startLog = s", started"
+ val startLog = s"\\[KafkaServer id=$i\\] started"
Review comment:
This might allow you to avoid escape chars.
```suggestion
val startLog = s"""[KafkaServer id=$i] started"""
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4802: upgrade
kafka server version from 0.11.0.1 to 2.3.1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4802: upgrade kafka server version from 0.11.0.1 to 2.3.1
URL: https://github.com/apache/openwhisk/pull/4802#issuecomment-581713279
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=h1) Report
> Merging [#4802](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/93f0bc602766e6be8744cfc89bdcf5d63d4ba55b?src=pr&el=desc) will **decrease** coverage by `6.4%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk/pull/4802/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4802 +/- ##
==========================================
- Coverage 84.87% 78.46% -6.41%
==========================================
Files 197 197
Lines 8879 8879
Branches 607 607
==========================================
- Hits 7536 6967 -569
- Misses 1343 1912 +569
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.61%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=footer). Last update [93f0bc6...f8848a9](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4802: [WIP] kafka server
version currency
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4802: [WIP] kafka server version currency
URL: https://github.com/apache/openwhisk/pull/4802#issuecomment-581713279
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=h1) Report
> Merging [#4802](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/eb29fe5cd0ce2f46ca507c4acbe40acc3818d9b9?src=pr&el=desc) will **decrease** coverage by `6.9%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk/pull/4802/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4802 +/- ##
==========================================
- Coverage 85.18% 78.28% -6.91%
==========================================
Files 197 197
Lines 8843 8879 +36
Branches 606 607 +1
==========================================
- Hits 7533 6951 -582
- Misses 1310 1928 +618
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.23%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/openwhisk/pull/4802/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=footer). Last update [eb29fe5...750c110](https://codecov.io/gh/apache/openwhisk/pull/4802?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services