You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/07 09:52:00 UTC

[jira] [Commented] (HADOOP-18482) ITestS3APrefetchingInputStream does not skip if no CSV test file available

    [ https://issues.apache.org/jira/browse/HADOOP-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613998#comment-17613998 ] 

ASF GitHub Bot commented on HADOOP-18482:
-----------------------------------------

dannycjones opened a new pull request, #4983:
URL: https://github.com/apache/hadoop/pull/4983

   ### Description of PR
   
   This test still runs (and fails) when we set the CSV file configuration to empty. It's meant to skip.
   
   ### How was this patch tested?
   
   Run against bucket in `eu-west-1`. Also run against a private S3 endpoint that needed the entry disabling.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> ITestS3APrefetchingInputStream does not skip if no CSV test file available
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-18482
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18482
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.4
>            Reporter: Daniel Carl Jones
>            Assignee: Daniel Carl Jones
>            Priority: Minor
>
> We should use S3ATestUtils.getCSVTestFile(conf) to skip if the property is empty (single space).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org