[GitHub] [pinot] richardstartin edited a comment on pull request #7617: Use maxEndTimeMs for merge/roll-up delay metrics.

[GitBox <gi...@apache.org>]

richardstartin edited a comment on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949950995


   You're right, `System.nanoTime()` does not record wall time. ~`System.currentTimeMillis() - bufferTimeMs` is an elapsed time (a duration), unless I'm missing something? The problem is that the expression `(Math.min(System.currentTimeMillis() - bufferTimeMs, maxEndTimeMs) - watermarkMs) / bucketTimeMs` can produce negative delays, which doesn't make sense.~ 
   
   I see where `bufferMs` etc. come from now, ignore my concerns.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org